Skip to content

Commit 6c58133

Browse files
committed
[fuchsia] Remove deprecation warning suppression
These were added in flutter#50358 as we were originally planning on removing the vfs::ComposedPseudoDir and vfs::LazyDir types from the SDK VFS. However, we have dropped the deprecation in https://fxrev.dev/1123733 and are supporting these at all current API levels again.
1 parent 3fbf7be commit 6c58133

File tree

3 files changed

+1
-16
lines changed

3 files changed

+1
-16
lines changed

shell/platform/fuchsia/dart_runner/dart_component_controller.cc

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -215,15 +215,10 @@ bool DartComponentController::CreateAndBindNamespace() {
215215
// That will prevent FL-175 for public directory
216216
fdio_service_connect_at(dart_outgoing_dir_ptr_.channel().get(), "svc",
217217
dart_public_dir.NewRequest().TakeChannel().release());
218-
219-
#pragma clang diagnostic push
220-
#pragma clang diagnostic ignored "-Wdeprecated-declarations"
221-
218+
222219
auto composed_service_dir = std::make_unique<vfs::ComposedServiceDir>();
223220
composed_service_dir->set_fallback(std::move(dart_public_dir));
224221

225-
#pragma clang diagnostic pop
226-
227222
// Clone and check if client is servicing the directory.
228223
dart_outgoing_dir_ptr_->Clone(
229224
fuchsia::io::OpenFlags::DESCRIBE |

shell/platform/fuchsia/flutter/component_v2.cc

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -261,14 +261,9 @@ ComponentV2::ComponentV2(
261261
fdio_service_connect_at(directory_ptr_.channel().get(), "svc",
262262
request.release());
263263

264-
#pragma clang diagnostic push
265-
#pragma clang diagnostic ignored "-Wdeprecated-declarations"
266-
267264
auto composed_service_dir = std::make_unique<vfs::ComposedServiceDir>();
268265
composed_service_dir->set_fallback(std::move(flutter_public_dir));
269266

270-
#pragma clang diagnostic pop
271-
272267
// Clone and check if client is servicing the directory.
273268
directory_ptr_->Clone(fuchsia::io::OpenFlags::DESCRIBE |
274269
fuchsia::io::OpenFlags::CLONE_SAME_RIGHTS,

shell/platform/fuchsia/runtime/dart/utils/vmservice_object.h

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,6 @@
99

1010
namespace dart_utils {
1111

12-
#pragma clang diagnostic push
13-
#pragma clang diagnostic ignored "-Wdeprecated-declarations"
14-
1512
class VMServiceObject : public vfs::LazyDir {
1613
public:
1714
static constexpr const char* kDirName = "DartVM";
@@ -24,8 +21,6 @@ class VMServiceObject : public vfs::LazyDir {
2421
std::string name) const override;
2522
};
2623

27-
#pragma clang diagnostic pop
28-
2924
} // namespace dart_utils
3025

3126
#endif // FLUTTER_SHELL_PLATFORM_FUCHSIA_RUNTIME_DART_UTILS_VMSERVICE_OBJECT_H_

0 commit comments

Comments
 (0)