Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Net 4.5 support is now problematic #89

Closed
flytzen opened this issue Dec 26, 2021 · 4 comments
Closed

Net 4.5 support is now problematic #89

flytzen opened this issue Dec 26, 2021 · 4 comments

Comments

@flytzen
Copy link
Collaborator

flytzen commented Dec 26, 2021

I have just set up a new computer and it is no longer possible to add a developer pack for .Net 4.5; only 4.5.1 and 4.5.2 are available.
I can still compile from the commandline, but VS 2022 won't compile the solution.
If we change support to 4.5.2, we'll have to increment the major version number. But, when #69 is resolved, we will almost certainly need to drop support for 4.5.x anyway - so probably better to wait and see what the next version of QR Coder supports, align ourselves with that and release a major version then?

@ahwm
Copy link
Collaborator

ahwm commented Dec 26, 2021

We'll need to add net60 support then as well, so that makes sense.

@ahwm
Copy link
Collaborator

ahwm commented Jan 4, 2022

@flytzen @BrandonPotter additional idea for a 3.0 - what if we completely decouple from a QR generator and leave it up to the developer to choose a library? Thoughts?

@flytzen
Copy link
Collaborator Author

flytzen commented Jan 5, 2022

@flytzen @BrandonPotter additional idea for a 3.0 - what if we completely decouple from a QR generator and leave it up to the developer to choose a library? Thoughts?

I see where you are coming from....
But, I think it makes it more difficult to pick up for a consumer and I don't see it adding any value for them? I like that it "just works" right now and judging by some of the support questions we've had, I think some of the consumers would quickly give up if we asked them to do this themselves.

If we want to speed up .Net 6.0, we can just change the library we use. We can even multi-target it so we use different libraries on different framework versions, if needed. In that case, we just need to make sure the "size" parameter produces consistently sized images across frameworks.

@flytzen
Copy link
Collaborator Author

flytzen commented May 2, 2022

Related to #107

@flytzen flytzen closed this as completed May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants