Should I add Dark = true

[wormeyman]

https://github.com/adobe/brackets/blob/b568b676e4d2fe0aadfb757e39cfd52444ea3101/src/extensions/default/ThorDarkTheme/package.json#L12

Shows an added entry in the theme file for thor dark, is this a permanent inclusion? If i am jumping the gun i am sorry just wondering what this does and if i should include it.

[MiguelCastillo]

Hey Eric, so the flag won't do much right now. But we are planning on making use of it at later point. I wouldn't really worry about adding right now.

[wormeyman]

ok thanks.

[MiguelCastillo]

Your welcome

[mackenza]

I added it to Railcasts and Envy... then I don't need to change when they make use of it ;)

[wormeyman]

Good plan @mackenza

[MiguelCastillo]

@wormeyman @mackenza I have added a class in the DOM and we are making use of it now. So, if you don't use the dark flag the theme will probably render a bit differently. The flag only currently affects scrollbars and inline editors.

[wormeyman]

Thanks for the heads up Miguel i am going to re-open this to double check that everything still works ok.

[mackenza]

Both Railcasts and Envy have dark: true. Which commits are affecting inline editors @MiguelCastillo ? My scrollbars seem fine (although having a dark scroll bar on an otherwise light dialog like the extension manager looks a bit odd), but my inline editors are mostly unreadable, even with the new "dark" default theme.

[wormeyman]

@mackenza my son deleted your comment, so sorry!

[MiguelCastillo]

Haha!