fix: Fixed crash when no external links were saved

Author: BossSloth

backend/install_extension/extension_builder.lua

@@ -1,7 +1,8 @@
 -- Extension settings builder for Chrome preferences
 
 local sys_utils = require("utils")
-local install_utils = require("install_extension.utils")
+local install_utils = require("install_extension.json_helpers")
+local json = require("json")
 
 local M = {}
 
@@ -28,23 +29,23 @@ function M.build_extension_settings(extension_dir, manifest)
 
     return {
         active_permissions = {
-            api = #api_permissions > 0 and api_permissions or install_utils.empty_array(),
+            api = #api_permissions > 0 and api_permissions or json.empty_array,
             explicit_host = { "<all_urls>" },
-            manifest_permissions = install_utils.empty_array(),
+            manifest_permissions = json.empty_array,
             scriptable_host = { "<all_urls>" },
         },
         commands = {},
-        content_settings = install_utils.empty_array(),
+        content_settings = json.empty_array,
         creation_flags = 38,
         first_install_time = file_time,
         from_webstore = false,
         granted_permissions = {
-            api = #api_permissions > 0 and api_permissions or install_utils.empty_array(),
+            api = #api_permissions > 0 and api_permissions or json.empty_array,
             explicit_host = { "<all_urls>" },
-            manifest_permissions = install_utils.empty_array(),
+            manifest_permissions = json.empty_array,
             scriptable_host = { "<all_urls>" },
         },
-        incognito_content_settings = install_utils.empty_array(),
+        incognito_content_settings = json.empty_array,
         incognito_preferences = {},
         last_update_time = file_time,
         location = 4, -- kUnpacked (developer mode)

backend/install_extension/utils.lua

@@ -2,14 +2,6 @@
 
 local M = {}
 
--- Helper to create empty arrays that serialize as [] not {}
--- cjson treats tables with no elements ambiguously, this ensures array serialization
-function M.empty_array()
-    local arr = {}
-    setmetatable(arr, { __jsontype = "array" })
-    return arr
-end
-
 -- Ensure nested table path exists, creating tables as needed
 -- Usage: ensure_nested(t, "a", "b", "c") ensures t.a.b.c exists
 function M.ensure_nested(t, ...)

backend/main.lua

@@ -19,12 +19,12 @@ function GetPluginDir()
     return fs.parent_path(backend_path)
 end
 
----@return table|string
+---@return string
 function GetExternalLinks()
     local plugin_dir = GetPluginDir()
     if not plugin_dir then
         logger:error("Failed to get plugin directory")
-        return utils.empty_array()
+        return "[]"
     end
 
     local external_links_path = fs.join(plugin_dir, EXTENDIUM_EXTERNAL_LINKS_FILE)
@@ -38,7 +38,7 @@ function GetExternalLinks()
         end
     end
 
-    return utils.empty_array()
+    return "[]"
 end
 
 ---@param external_links string

backend_lib/json.lua

@@ -89,4 +89,8 @@ cjson_safe.null = cjson.null
 cjson_safe._NAME = cjson._NAME
 cjson_safe._VERSION = cjson._VERSION
 
+---Create an empty JSON array
+---@type table # Empty JSON array
+cjson.empty_array = cjson.empty_array
+
 return cjson

frontend/index.tsx

@@ -30,10 +30,8 @@ export default async function PluginMain(): Promise<void> {
   const { openLinksInCurrentTab } = useSettingsStore.getState();
   UpdateSettings({ settings: JSON.stringify({ openLinksInCurrentTab }) });
 
-  const extendiumInfo = await GetExtendiumInfo();
-  if (extendiumInfo !== undefined) {
-    initInfos(JSON.parse(extendiumInfo) as ExtendiumInfo);
-  }
+  const extendiumInfo = await GetExtendiumInfo() ?? '{}';
+  initInfos(JSON.parse(extendiumInfo) as ExtendiumInfo);
 
   const wnd = g_PopupManager.GetExistingPopup('SP Desktop_uid0');
   if (wnd) {