Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistency Between Documented and Actual API Responses: user_id Missing in /users Endpoint Responses #5178 #5178

Closed
ln-ws opened this issue Aug 26, 2024 · 4 comments

Comments

@ln-ws
Copy link

ln-ws commented Aug 26, 2024

Describe the Bug

The API documentation indicates that responses from the /users endpoint should include both id and user_id properties. However, in practice, the actual API responses only contain the id property, and the user_id property is missing.

Steps to Reproduce

  1. Send a LIST request to the /users endpoint on your BookStack server.
  2. Review the response returned by the server.
  3. Notice that the user_id property is missing from the response, despite being documented.

Expected Behaviour

The response from the /users endpoint should include both id and user_id properties, where the user_id property matches the value of the id property for each user object within the data array.

Screenshots or Additional Context

No response

Browser Details

No response

Exact BookStack Version

v24.05.3

@ln-ws ln-ws added the 🐛 Bug label Aug 26, 2024
@ln-ws ln-ws changed the title The property user_id exists in the example responses, but doesn't exist in actual responses Inconsistency Between Documented and Actual API Responses: user_id Missing in /users Endpoint Responses #5178 Aug 26, 2024
@ssddanbrown
Copy link
Member

I'm deleting all above comments as I don't see any as relevant to the discussion, or they contain links to downloads on other sites that I'm not comfortable with having here, and/or they contain claims I'm not going to validate.
Any further links to external downloads (including archive links) will result in a block for BookStackApp projects.

@BookStackApp BookStackApp deleted a comment Aug 26, 2024
@BookStackApp BookStackApp deleted a comment Aug 26, 2024
@BookStackApp BookStackApp deleted a comment Aug 26, 2024
@BookStackApp BookStackApp deleted a comment Aug 26, 2024
@BookStackApp BookStackApp deleted a comment Aug 26, 2024
@BookStackApp BookStackApp deleted a comment Aug 26, 2024
@ssddanbrown ssddanbrown added this to the BookStack v24.05.4 milestone Aug 26, 2024
@ssddanbrown
Copy link
Member

Thanks for raising @ln-ws.
I can confirm the example response does not match the actual response.
I'll just look to remove the user_id from the example response. The id value should be used instead.

@ln-ws
Copy link
Author

ln-ws commented Aug 26, 2024

Thank you

@ssddanbrown
Copy link
Member

Thanks again @ln-ws, this has been addressed as part of 1f25062 to be part of the next patch release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

4 participants
@ssddanbrown @ln-ws and others