Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Right to Left direction does not affect the callouts #5104

Closed
okaeiz opened this issue Jul 6, 2024 · 1 comment
Closed

Right to Left direction does not affect the callouts #5104

okaeiz opened this issue Jul 6, 2024 · 1 comment
Labels
🎨 Design 🐛 Bug 💆 UX
Milestone
BookStack v24.05.3

Comments

@okaeiz
Copy link

okaeiz commented Jul 6, 2024

Describe the Bug

When I create an RTL callout, the callout box is rendered LTR (the icon is displayed on the left).

Capture

Steps to Reproduce

  1. In the Persian UI, select a text, change its direction to RTL and change its style to Callouts.
  2. It is the same as when the text direction is LTR.

Expected Behaviour

I expect the callout box to be rendered accordingly.

Screenshots or Additional Context

No response

Browser Details

No response

Exact BookStack Version

v24.05.1
@okaeiz okaeiz added the 🐛 Bug label Jul 6, 2024
@ssddanbrown ssddanbrown added this to the BookStack v24.05.3 milestone Jul 6, 2024
ssddanbrown added a commit that referenced this issue Jul 14, 2024
@ssddanbrown
Styles: Improved callout RTL support
95c3cc5 
Will now adapt using logical styles where supported, will fallbacks
to old fixed LTR positioning where not supported.
For #5104
@ssddanbrown
Copy link
Member

Thanks for reporting @okaeiz.
I've now addressed this for most scenarios via commit 95c3cc5.
Where more modern CSS support (or RTL support) is lacking (old browsers, export formats) these may still default back to RTL display.
This will be part of the next patch release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🎨 Design 🐛 Bug 💆 UX
Milestone
BookStack v24.05.3
Development

No branches or pull requests
2 participants
@ssddanbrown @okaeiz