Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When replacing an image the new image is not shown until you do a page reload #4767

Open
jasell opened this issue Jan 11, 2024 · 2 comments
Open

Comments

@jasell
Copy link

jasell commented Jan 11, 2024

Describe the Bug

When replacing an image the new image is not shown until you do a page reload

Steps to Reproduce

  1. Go to the image library
    image
  2. Select an image, and select to replace the image
    image
  3. Browse for a new image and select it, see the notification as confirmation
    image
  4. Wait for the notification to fade out, now your new image is no long visible
    image
  5. Do a page reload to see the image update
    image
  6. open the image archive again and see your update image
    image

Expected Behaviour

As the new image is loaded it should update both in the image archive and throughtout in my page

Screenshots or Additional Context

No response

Browser Details

Win 11, Chrome

Exact BookStack Version

Demo page

@ssddanbrown
Copy link
Member

Hi @jasell,
Yeah, this is is known side affect of performing an in-place change of image, where caching is active.
We could add cache-invalidating query additions to these, but that's getting pretty hacky, especially for images used in-content already, outside of the image manager itself.
Otherwise, there could be other options with certain image storage options we provide, but not sure I'd want to add that complexity for a minor element.

Could be something best pracitally solved to added wording to advise of this scearnio, warning the user old images may be shown for a little while.

@jasell
Copy link
Author

jasell commented Jan 11, 2024

A simple solution could be to notify the user to do a page reload or F5 to see the effect of the update image.
The Message could be visible until the page is reloaded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants