Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support updating of user details upon OIDC/SAML2/LDAP Login #3771

Open
danicc097 opened this issue Oct 8, 2022 · 3 comments
Open

Support updating of user details upon OIDC/SAML2/LDAP Login #3771

danicc097 opened this issue Oct 8, 2022 · 3 comments

Comments

@danicc097
Copy link

Describe the Bug

When user info is changed in the identity provider, changes are not reflected in the bookstack database. Only groups are synced at the moment AFAICT:

try {
$user = $this->registrationService->findOrRegister(
$userDetails['name'],
$userDetails['email'],
$userDetails['external_id']
);
} catch (UserRegistrationException $exception) {
throw new OidcException($exception->getMessage());
}
if ($this->shouldSyncGroups()) {
$groups = $userDetails['groups'];
$detachExisting = $this->config()['remove_from_groups'];
$this->groupService->syncUserWithFoundGroups($user, $groups, $detachExisting);
}

Steps to Reproduce

  1. Register a new user in the IDP.
  2. Login in Bookstack
  3. Update the user in the IDP
  4. Logout of Bookstack, clear cache and log and back in
  5. Changes not reflected

Expected Behaviour

I'd expect changes from the IDP to be reflected automatically

Screenshots or Additional Context

No response

Browser Details

No response

Exact BookStack Version

22.09

PHP Version

No response

Hosting Environment

Ubuntu 20.04, docker image

@ssddanbrown
Copy link
Member

Yeah, this is the case with all external auth options. I'm gonna re-categorise this as a feature request since it's not specifically a bug in existing supported functionality.

@ssddanbrown ssddanbrown changed the title Name, email not synced with OIDC Support updating of user details upon OIDC/SAML2/LDAP Login Oct 8, 2022
@Misaka-L
Copy link

Misaka-L commented Jul 6, 2024

@ssddanbrown Sorry to disturb, but this issue has been hanging on for 2 years and I want to ask if there is any progress on it?

@ssddanbrown
Copy link
Member

@Misaka-L No, as above I see this as a feature request rather than an issue, so I'm not really aiming to address but more awaiting to validate as a need to justify the added desired complexity, for which there has been very little demand so far.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants