Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Password change does not ask for current password #1457

Open
swierckx opened this issue May 22, 2019 · 2 comments
Open

Password change does not ask for current password #1457

swierckx opened this issue May 22, 2019 · 2 comments

Comments

@swierckx
Copy link

Describe the bug
When a user changes his/her password the application does not request the current password to validate the user. It is a security best practice to re-validate the authentication when performing sensitive operations such as a password change.

Steps To Reproduce
Steps to reproduce the behavior:

  1. Go to your profile
  2. Enter the same, new password twice
  3. Save
  4. The current password is not requested

Expected behavior
Add a text box to enter the current password for all sensitive actions.

Your Configuration (please complete the following information):

  • Exact BookStack Version (Found in settings): v0.26.1
  • PHP Version: 7.2
  • Hosting Method (Nginx/Apache/Docker): Apache
@ssddanbrown
Copy link
Member

Thanks for the suggestion @swierckx, That's a good idea. Will have to support the case of an admin-style user changing the password on behalf of anther user, I'd imagine the admin would confirm their own password but need to take care with the UX to ensure it's not confusing in regards to what password is being requested.

@Cave-Johnson
Copy link

Perhaps the best method would be to confirm the admins password before access is granted to the settings area entirely and then only show the new password and confirm password boxes for the admin user.

For a standard user have a box above the new password and confirm password boxes asking for the users current password.

It would also be really neat to have bookstack generate a random password as a suggestion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants