Improve parsing#4
Open
guilhermedemouraa wants to merge 3 commits into
Open
Conversation
Collaborator
guilhermedemouraa
commented
Mar 17, 2026
guilhermedemouraa
commented
- Sanitize names
- Allow blank spaces
- Allow blank space before semicolon
* Sanitize names * Allow blank spaces * Allow blank space before semicolon
guilhermedemouraa
force-pushed
the
u/gui/improve-parsing-robustness
branch
from
0dc5514 to
74574dd
Compare
- Fix normalize_dbc to only strip blank lines within BO_/SG_ message sections, preserving blank lines in header sections (NS_, BS_, BU_) - Update all test assertions to use snake_case field names - Update dbc_signals filter to use snake_case names - Update doctest example Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Some DBC files have "SG_ NAME:" without space before colon. The can-dbc parser requires "SG_ NAME :". Normalize this in the preprocessing step. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.