Skip to content

Conversation

@jamesros161
Copy link
Contributor

This resolves #26 by causing a full prefiew refresh when header layout changes are made.

@rramo012
Copy link
Member

I would prefer the solution to be fixing the transport mode instead of falling back to refresh. Have you tried fixing the auto transport mode instead of disabling?

@rramo012 rramo012 self-requested a review March 20, 2020 17:12
Copy link
Member

@rramo012 rramo012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's fix this without changing the behavior of the control to refresh the entire page

@jamesros161
Copy link
Contributor Author

Let's fix this without changing the behavior of the control to refresh the entire page

I spent almost two whole days fighting with this to try and get it to work with the partial refresh, but something just isn't quite clicking. I referenced this as well, and based on that article, it SHOULD be working but it isn't.

Interestingly enough, I was able to get it halfway working. When you would try to change the layout, it would perform the partial refresh, and while it was doing the partial refresh ( the opacity is lighter on it until it completes ) you would see the correct menus, with the submenus and everything. But then, when that completes, it would loose that.

@rramo012
Copy link
Member

Okay, understood. One of my concerns is introducing new issues by changing the behavior.
I'll merge it in, and we can make a ticket revert back the behavior of the transport and fix this issue.

@rramo012 rramo012 merged commit 2b7f98a into master Mar 20, 2020
@rramo012 rramo012 deleted the crio-26 branch March 20, 2020 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

reinit smartmenus on customizer partial refreshes of dynamic layout sections

3 participants