Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skript-holo conflicting with Skript's line expression #1

Open
Wealthyturtle opened this issue Nov 17, 2019 · 1 comment
Open

skript-holo conflicting with Skript's line expression #1

Wealthyturtle opened this issue Nov 17, 2019 · 1 comment

Comments

@Wealthyturtle
Copy link

Wealthyturtle commented Nov 17, 2019

Script

command /test:
    trigger:
        set {_i} to diamond
        set line 1 of {_i}'s lore to "Test"
        broadcast "-%line 1 of {_i}'s lore%"

Running the above script will produce a result of -Test when running Skript 2.4-beta10 only.

However, when running the above script with skript-holo 1.0.2, it instead produces a result of -<none>, leading me to believe that this is caused by some conflict of expression with Skript's line expression.

Versions (All are latest, except for the Spigot jar)

  • Skript: 2.4-beta10
  • skript-holo: 1.0.2
  • Holographic Displays: 2.4.0
  • ProtocolLib 4.4.0
  • Server: git-Spigot-9de398a-9c887d4 (MC: 1.14.4)
@Wealthyturtle Wealthyturtle changed the title skript-holo conflicting with Skript's lore expression skript-holo conflicting with Skript's line expression Nov 17, 2019
@Blueyescat
Copy link
Owner

So it uses this syntax:

[the] line %number% of [holo[gram][s]] %holograms% 

The parser should be reading it like (line 1 of hologram {_i})'s lore
can not be reading like line 1 of hologram ({_i}'s lore).

In this case the line expression returns a HologramLine, and it has a converter to ItemType, this should be why. Skript's ExprLore is being an issue in this case because it is weird as known, if it was something like line 1 of %strings% this wouldn't happen; parser can read it like line 1 of ({_i}'s lore).

set line 1 of lore of {_i} to "Test" should work.

I woudn't want to break existing scripts but i'm not sure :{

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants