Bump Bevy to 0.15.0-rc.3. #27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
I'll double check this against what I've done with #26, but thanks for the PR. If bevy v0.15 goes live before I get round to finishing off that other PR, I'll likely just merge this PR first and rebase the other one on top to unblock folks. |
Bluefinger
reviewed
Nov 10, 2024
Bluefinger
requested changes
Nov 10, 2024
Owner
Bluefinger
left a comment
Bluefinger
left a comment
There was a problem hiding this comment.
LGTM, just needs to have that Typed trait constraint moved to be part of SeedableEntropySource and then it is more or less ready to merge.
This trait already holds the majority of trait requirements, so we might as well add it there as well.
Seed512 doesn't impl `Typed` so reflection is broken here because of it.
Bluefinger
approved these changes
Nov 11, 2024
Owner
Bluefinger
left a comment
Bluefinger
left a comment
There was a problem hiding this comment.
Looking good, and good job! Thanks for being patient with some of my feedback 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now we're ready for the 0.15 release!
Some notable weirdness to this bump:
Reflecthas been split intoPartialReflectandReflect. TL;DR -PartialReflectjust means that you can access the fields of the represented type.Reflecton the other hand is an actual instance of the represented type. (or at least something like that). Regardless,ReflectDeserializernow spits outPartialReflecttypes, which means we need to do more work to extract the correct types.