Clarify beginning of user guide (loading data) #430
Merged
+20
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdumusc
requested review from
tribal-tec,
karjonas and
favreau
and removed request for
tribal-tec and
karjonas
rolandjitsu
reviewed
Jun 14, 2018
| @@ -22,6 +22,8 @@ | |||
|
|
|||
| #include <brayns/common/renderer/FrameBuffer.h> | |||
|
|
|||
| #ifdef BRAYNS_USE_FREEIMAGE | |||
There was a problem hiding this comment.
This is not user guide 😄
There was a problem hiding this comment.
That's why this commit is called "Fix build without FreeImage" ;-)
There was a problem hiding this comment.
I was looking at the PR name, and it can be misleading when you search your PR history, since you probably squash the commits into a single one.
There was a problem hiding this comment.
I'm not going to squash the commits, and I don't want to open a separate PR for such a small fix...
karjonas
approved these changes
Jun 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.