Skip to content

Replace react-loadable with loadable-components #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

artalat
Copy link
Contributor

@artalat artalat commented Aug 19, 2019

Closes #45

@codecov
Copy link

codecov bot commented Aug 19, 2019

Codecov Report

Merging #133 into develop will decrease coverage by 0.54%.
The diff coverage is 42.85%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #133      +/-   ##
===========================================
- Coverage    99.51%   98.96%   -0.55%     
===========================================
  Files          140      141       +1     
  Lines         1437     1447      +10     
  Branches       230      231       +1     
===========================================
+ Hits          1430     1432       +2     
- Misses           6       13       +7     
- Partials         1        2       +1
Impacted Files Coverage Δ
src/utils/index.ts 100% <100%> (ø) ⬆️
src/utils/withLoadable.tsx 36.36% <36.36%> (ø)
src/registries/ComponentRegistry.tsx 96.66% <50%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c17a504...fa8aab4. Read the comment docs.

@artalat
Copy link
Contributor Author

artalat commented Aug 20, 2019

This seems to be a good reference of a compat library https://github.com/mohsen1/apollo-react-async-ssr/pull/2/files

@artalat artalat added this to the v5.0.0 milestone Aug 20, 2019
@artalat artalat added the enhancement New feature or request label Aug 20, 2019
@ammarkhan967
Copy link
Contributor

its partially done half work is still require to complete

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants