Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Line Following with Agent-Based Decision Making #147

Merged
merged 39 commits into from
Sep 11, 2024
Merged

Conversation

akrambzeo
Copy link
Collaborator

Implemented an agent for decision making in line following, added a trajectory buffer and networks, and created a plot file for analysis of the results.

@gabryelreyes gabryelreyes changed the base branch from main to base/RL August 19, 2024 06:46
Copy link
Owner

@BlueAndi BlueAndi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please increase number of PRs and keep logical changes small.

lib/APPReinforcementLearning/src/App.cpp Outdated Show resolved Hide resolved
lib/APPReinforcementLearning/src/App.h Outdated Show resolved Hide resolved
lib/APPReinforcementLearning/src/App.cpp Outdated Show resolved Hide resolved
lib/APPReinforcementLearning/src/ReadyState.cpp Outdated Show resolved Hide resolved
webots/controllers/RL_Supervisor/agent.py Outdated Show resolved Hide resolved
webots/controllers/RL_Supervisor/agent.py Show resolved Hide resolved
webots/controllers/RL_Supervisor/agent.py Outdated Show resolved Hide resolved
webots/controllers/RL_Supervisor/agent.py Show resolved Hide resolved
lib/APPReinforcementLearning/src/App.h Outdated Show resolved Hide resolved
lib/APPReinforcementLearning/src/ReadyState.h Outdated Show resolved Hide resolved
Copy link
Collaborator

@gabryelreyes gabryelreyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For every python function that returns something, please try to use type-hinting for the return values on the function definition. This helps better follow and understand the code

lib/APPReinforcementLearning/src/ReadyState.h Outdated Show resolved Hide resolved
lib/APPReinforcementLearning/src/App.cpp Outdated Show resolved Hide resolved
lib/APPReinforcementLearning/src/App.cpp Outdated Show resolved Hide resolved
lib/APPReinforcementLearning/src/App.h Outdated Show resolved Hide resolved
webots/controllers/RL_Supervisor/rl_supervisor.py Outdated Show resolved Hide resolved
webots/controllers/RL_Supervisor/rl_supervisor.py Outdated Show resolved Hide resolved
webots/controllers/RL_Supervisor/rl_supervisor.py Outdated Show resolved Hide resolved
webots/controllers/RL_Supervisor/rl_supervisor.py Outdated Show resolved Hide resolved
webots/controllers/RL_Supervisor/trajectory_buffer.py Outdated Show resolved Hide resolved
{
/* Failed to send data to the supervisor. Go to error state. */
ErrorState::getInstance().setErrorMsg("DSF");
/* Failed to send Senssor data to the supervisor. Go to error state. */
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works. But could be done better by using if-else blocks

Akram added 3 commits September 10, 2024 13:29
…nto feature/RL

Merged branch 'feature/RL' into 'feature/RL' to incorporate upstream updates and resolve conflicts
webots/controllers/RL_Supervisor/requirements.txt Outdated Show resolved Hide resolved
webots/controllers/RL_Supervisor/requirements.txt Outdated Show resolved Hide resolved
webots/controllers/RL_Supervisor/requirements.txt Outdated Show resolved Hide resolved
@hoeftjch hoeftjch self-requested a review September 11, 2024 08:31
Copy link
Collaborator

@hoeftjch hoeftjch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reinforcement training loop runs as expected. Further architecture changes needed to drastically reduce coupling between environment and RL Agent. This will be done in future updates regarding issue #156.

@gabryelreyes gabryelreyes merged commit f7e7f00 into base/RL Sep 11, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants