Skip to content
This repository was archived by the owner on Jan 2, 2025. It is now read-only.

Conversation

@anastasiya1155
Copy link
Collaborator

No description provided.

@ggordonhall ggordonhall requested review from calyptobai, ggordonhall and oppiliappan and removed request for calyptobai November 15, 2023 11:48
anastasiya1155 and others added 2 commits November 15, 2023 06:59
…lters-in-ui

# Conflicts:
#	client/src/locales/en.json
#	client/src/locales/es.json
#	client/src/locales/it.json
#	client/src/locales/ja.json
#	client/src/locales/zh-CN.json
@gitpod-io
Copy link

gitpod-io bot commented Nov 15, 2023

@rsdy rsdy force-pushed the anastasiia/blo-1817-support-lang-and-file-filters-in-ui branch from 1fbed4b to 6b016c7 Compare November 15, 2023 14:14
@rsdy rsdy force-pushed the anastasiia/blo-1817-support-lang-and-file-filters-in-ui branch from 6b016c7 to 3bfcfb2 Compare November 15, 2023 14:35
pub struct Exchange {
pub id: uuid::Uuid,
pub query: SemanticQuery<'static>,
pub raw_query: String,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we make the raw_query a field on SemanticQuery?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could, but it's easier for the frontend to pick it from here.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't matter much for the FE, can change if you want

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anastasiya1155 I have made this change now

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated the FE

Copy link
Contributor

@oppiliappan oppiliappan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code changes lgtm.

rsdy and others added 7 commits November 16, 2023 15:40
Co-authored-by: Gabriel Gordon-Hall <ggordonhall@gmail.com>
…lters-in-ui

# Conflicts:
#	client/src/locales/en.json
#	client/src/locales/es.json
#	client/src/locales/it.json
#	client/src/locales/ja.json
#	client/src/locales/zh-CN.json
@ggordonhall ggordonhall merged commit 39d94a1 into main Nov 20, 2023
@ggordonhall ggordonhall deleted the anastasiia/blo-1817-support-lang-and-file-filters-in-ui branch November 20, 2023 12:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants