Increase rangeproof ct bits from 36 to 52

In line with elements update

ElementsProject/elements#834

Also removed the min/max construct, again in line with elements

Author: jkauffman1

docs/source/gdk-json.rst

@@ -740,7 +740,7 @@ Networks list JSON
         51840,
         65535
       ],
-      "ct_bits": 36,
+      "ct_bits": 52,
       "ct_exponent": 0,
       "default_peers": [],
       "development": false,
@@ -805,7 +805,7 @@ Networks list JSON
         51840,
         65535
       ],
-      "ct_bits": 36,
+      "ct_bits": 52,
       "ct_exponent": 0,
       "default_peers": [],
       "development": true,

src/ga_tx.cpp

@@ -1070,8 +1070,7 @@ namespace sdk {
         const auto eph_keypair_pub = h2b(output.at("eph_keypair_pub"));
 
         const auto rangeproof = asset_rangeproof(value, pub_key, eph_keypair_sec, asset_id, abf, vbf, value_commitment,
-            script, generator, 1, std::min(std::max(net_params.ct_exponent(), -1), 18),
-            std::min(std::max(net_params.ct_bits(), 1), 51));
+            script, generator, 1, std::min(std::max(net_params.ct_exponent(), -1), 18), net_params.ct_bits());
 
         const auto surjectionproof = asset_surjectionproof(
             asset_id, abf, generator, get_random_bytes<32>(), input_assets, input_abfs, input_ags);

src/network_parameters.cpp

@@ -96,7 +96,7 @@ static std::map<std::string, std::shared_ptr<nlohmann::json>> registered_network
             { "default_peers", nlohmann::json::array() }, { "p2pkh_version", 57u }, { "p2sh_version", 39u },
             { "bech32_prefix", "lq" }, { "mainnet", true }, { "liquid", true }, { "development", false },
             { "policy_asset", "6f0279e9ed041c3d710a9f57d0c02928416460c4b722ae3457a11eec381c526d" },
-            { "blinded_prefix", 12u }, { "ct_exponent", 0 }, { "ct_bits", 36 },
+            { "blinded_prefix", 12u }, { "ct_exponent", 0 }, { "ct_bits", 52 },
             { "csv_buckets", std::vector<uint32_t>{ 25920, 51840, 65535 } }, { "bip21_prefix", "liquidnetwork" } })) },
 
     { "localtest-liquid",
@@ -111,7 +111,7 @@ static std::map<std::string, std::shared_ptr<nlohmann::json>> registered_network
             { "default_peers", nlohmann::json::array() }, { "p2pkh_version", 235u }, { "p2sh_version", 75u },
             { "bech32_prefix", "tb" }, { "mainnet", false }, { "liquid", true }, { "development", true },
             { "policy_asset", "5ac9f65c0efcc4775e0baec4ec03abdde22473cd3cf33c0419ca290e0751b225" },
-            { "blinded_prefix", 4u }, { "ct_exponent", 0 }, { "ct_bits", 36 },
+            { "blinded_prefix", 4u }, { "ct_exponent", 0 }, { "ct_bits", 52 },
             { "csv_buckets", std::vector<uint32_t>{ 144, 4320, 25920, 51840, 65535 } },
             { "bip21_prefix", "liquidnetwork" } })) },