Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select player count for batch create #114

Open
tdhsmith opened this issue Oct 6, 2020 · 2 comments
Open

Select player count for batch create #114

tdhsmith opened this issue Oct 6, 2020 · 2 comments
Labels
enhancement New feature or request target: user Issue that is relevant for end-users

Comments

@tdhsmith
Copy link
Contributor

tdhsmith commented Oct 6, 2020

With the basic batch create command, player count adjustment isn't necessary, since batch fill ignores any players with no data. However pre-filling data during batch create is very useful for values that apply to the overall event, and this ends up creating dummy players that only contain the pre-filled data. It'd be cleaner if you could simply set the player count when generating the CSV.

@Blesmol Blesmol added enhancement New feature or request target: user Issue that is relevant for end-users labels Oct 6, 2020
@Blesmol
Copy link
Owner

Blesmol commented Oct 6, 2020

I thought about having something like this as well, but currently gave it lower priority, as I process the CSV files using Excel anyways, and deleting some of the columns therein is only a couple of clicks. However, I agree that other people might do this in a different way and might be glad for such an option.

So yes, I think the proper way is to add an additional optional flag to the batch create command to give GMs the option to specify the number of players while keeping the current number of entries as default.

@Blesmol
Copy link
Owner

Blesmol commented Oct 6, 2020

Implementing an additional flag itself is not much work, but currently I still plan to have some proper overhaul of the whole configuration thingy, which is quite a mess at the moment. I'm planning to have a simple config interface that allows easy access both to the settings of command line flags and also to configuration stored either in the pfscf dir or in the users home dir.

Had a first look at the viper framework two weeks ago, but was not really convinced so far...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request target: user Issue that is relevant for end-users
Projects
None yet
Development

No branches or pull requests

2 participants