end of a SelectObjectBuilder<CriteriaBuilder<XXXX>>

[milesif]

Hi,

I have this code

 protected CriteriaBuilder<CourseResult> fillSelections() {
        SelectObjectBuilder<CriteriaBuilder<CourseResult>> sob = select("c", "id", "code", "name");
        sob = withSubscriptions(sob);
        sob = withWaitingConfirmation(sob);
        return sob.end();
    }

    private SelectObjectBuilder<CriteriaBuilder<CourseResult>> withSubscriptions(SelectObjectBuilder<CriteriaBuilder<CourseResult>> sob) {
        SubqueryBuilder<SelectObjectBuilder<CriteriaBuilder<CourseResult>>> sb = sob.withSubquery()
                .from(CourseAttendance.class, "ca")
                .select("count(*)")
                .where("c.id").eqExpression("ca.idCourse")
                .where("ca.role").eq(AttendanceRole.std);
        if (ctx.isClientScoped())
            sb = sb.where("ca.idClient").eq(ctx.getClientId());
        return sb.end();
    }

    private SelectObjectBuilder<CriteriaBuilder<CourseResult>> withWaitingConfirmation(SelectObjectBuilder<CriteriaBuilder<CourseResult>> sob) {
        SubqueryBuilder<SelectObjectBuilder<CriteriaBuilder<CourseResult>>> sb = sob
                .withSubquery()
                .from(Session.class, "s")
                .select("s.scheduleStatus").distinct()
                .where("c.id").eqExpression("s.idCourse")
                .where("s.scheduleStatus").eq(SessionScheduleStatus.ended);
        return sb.end();
    }

both the method withSubscriptions(SelectObjectBuilder) and withWaitingConfirmation(SelectObjectBuilder) take an argument of type SelectObjectBuilder, which I am using to add fields to the select clause. Both methods call withSubquery on it and after building the query, call end() on the SubqueryBuilder wich returns the original SelectObjectBuilder.

The problem is that everything works if I only use one of them (that is, if in the method fillSelections I comment the call to withSubscriptions or that to withWaitingConfirmation), but when I decomment both of them I get "A builder was not ended properly".

I thought that calling SubqueryBuilder.end() would bring me back to SelectObjectBuilder on which I could call again withSubquery() to build another subquery, then calling SubqueryBuilder.end() again would bring me back again to SelectObjectBuilder.

There is someting I misunderstood?
May I should use withSubqueries() to start multiple subQueries?

thanks for your help

[beikov]

This looks like a bug to me. The subqueryStartMarker in SelectObjectBuilderImpl is never reset to null in com.blazebit.persistence.impl.builder.object.SelectObjectBuilderImpl#onBuilderEnded(com.blazebit.persistence.impl.SubqueryInternalBuilder<com.blazebit.persistence.SelectObjectBuilder<T>>) which is probably why this happens. I'd appreciate if you could create a bug ticket for this and potentially also a PR with a fix.

[milesif]

I created issue [(https://github.com//issues/2006)]

thanks

Francesco