Getters of constructable EntityViews

[mahairod]

So we start with this, @beikov:

I also wish to mention that it costs me a lot of time to make getters in constructor version actually work. There is unusual logic for handling getters in abstract subview classes. Getters and fields must be in the same class in inheritance hierarchy. Moreover, assignment in constructor should be done with reference to actual field declarator, which is often not true and is hard to comply with.

In brief: I assume you can look at

AttributeInfo[] com.blazebit.persistence.view.impl.metamodel.AnnotationMappingReader.analyzeParameterToAccessorMapping(Class<?> entityViewClass, Constructor<?> canonicalConstructor, Map<String, AttributeInfo> fieldsToAccessors)

Here we have Map fieldsToAccessors as input. This is created somewhere above the stack. While it is created getters are found only if appropriate fields are already present in a list.

Then when further assignment analysis is made, there is condition on eqality of field owner and assignment context. It's not valid for derived classes when assigning to a visible public/protected field in parent class.

      AttributeInfo attributeInfo = (AttributeInfo)fieldsToAccessors.get(cp.getFieldrefName(cpIndex));
      if (attributeInfo != null && attributeInfo.className.equals(cp.getFieldrefClassName(cpIndex))) {
          parameterToAccessorMapping[stackSlotToParameterIndex(sourceOrigin, constructorParams)] = attributeInfo;
      }

[beikov]

Is this related to issue #1994 you posted? If not, it would be very helpful if you could post a reproducer for this issue e.g. based on one of our quickstart maven archetypes: https://github.com/Blazebit/blaze-persistence?tab=readme-ov-file#quickstart

[mahairod]

Yes, related. It's the same code

[mahairod]

hre is the code for class that caused the problem

	@EntityView(ru.elliptica.webid.ent.Validation.class)
	abstract class TimePeriodForValidation extends TimePeriodView {
		public TimePeriodForValidation(@Mapping("startTime") LocalDateTime startTime, @Mapping("endTime") LocalDateTime endTime) {
			super(startTime, endTime);
		}
	}

public abstract class TimePeriodView extends SimplePeriod {
	public TimePeriodView(LocalDateTime startTime, LocalDateTime endTime) {
		super(startTime, endTime);
	}
}

public class SimplePeriod extends TimePeriod {
	private LocalDateTime startDate;

	public SimplePeriod(LocalDateTime startDate) {
		this.startDate = startDate;
	}

	// need to make workaround here
	public SimplePeriod(LocalDateTime startDate, LocalDateTime endDate) {
		this.startDate = startDate;
		// need to make workaround here
		super.endDate = endDate;
	}

	public SimplePeriod(Date startDate) {
		this.startDate = LocalDateTime.ofInstant(startDate.toInstant(), ZoneId.of("UTC"));
	}

	@Override
	public LocalDateTime getStartDate() {
		return startDate;
	}

}

public abstract class TimePeriod implements AbstractPresence {
	public LocalDateTime endDate;

	public abstract LocalDateTime getStartDate();

	public LocalDateTime getEndDate() {
		return endDate !=null ? endDate : LocalDateTime.MAX;
	}

	@Override
	public TimePeriod period() {
		return this;
	}
}