feat: persist trace filters in URL search params#1079
Open
Harshith1702 wants to merge 1 commit into
Open
Conversation
Updated state initialization to use search parameters and added URL update functionality for filters.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose / Description
Persists trace list filters (
search,traceType,ide) in URL query params so filters survive page refreshes and shared links.Fixes
Closes #874
Approach
useSearchParamsandusePathnameto hydrate filter state from URL paramsrouter.replaceHow Has This Been Tested?
?ide=cursor&traceType=mcpopen the correctly filtered viewChecklist
git commit -s) per the DCO