Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow workbenches in BRJS libraries #950

Open
andy-berry-dev opened this issue Sep 4, 2014 · 2 comments
Open

allow workbenches in BRJS libraries #950

andy-berry-dev opened this issue Sep 4, 2014 · 2 comments

Comments

@andy-berry-dev
Copy link
Member

Like Blades some libraries provide UI components so it would be useful to allow workbench(es) for BRJS libraries.

@leggetter
Copy link
Contributor

By allowing libraries to have workbenches do we run the risk of the majority of coding moving to libraries, even when it's application specific? Is there anything we can do to guard against this happening? Or is this going to have to be something that falls under "good practice" and "culture"?

@james-shaw-turner
Copy link
Contributor

Yes we do run that risk. The reason for putting code into libraries is to make it shareable and reuse it. Generally the more generic code becomes the more expensive it is to write. Code that is reused needs well defined use cases, a good API as well as copious documentation.
The danger is that by making it more appealing (and easier) to put code into a library the temptation is to share it before it is ready. It then becomes more expensive to refactor the code because it breaks backwards compatibility and all the code that uses it also needs refactored.
I think the best answer is to make inter-blade communication easier (without breaking encapsulation) so people don't feel they have to put code into a library just so it can be used within multiple places in an App (this has happened at a client recently).Then libraries are only used for generic re-usable code.
So I think it is largely a matter of culture - although I think the culture change happens quite quickly (as it did with us) when you feel the pain of reusing code that isn't ready yet and hasn't been validated against multiple use-cases.

@andy-berry-dev andy-berry-dev changed the title allow workbenches in BRJS style libraries allow workbenches in BRJS libraries Oct 7, 2014
@andy-berry-dev andy-berry-dev added this to the Post 1.0 milestone Jan 7, 2015
@andy-berry-dev andy-berry-dev modified the milestones: 1.1, Post 1.0 May 19, 2015
@dchambers dchambers added this to the Post 1.0 milestone Jun 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants