Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw a nice exception if an invalid js-style is used #922

Open
thecapdan opened this issue Aug 22, 2014 · 4 comments
Open

Throw a nice exception if an invalid js-style is used #922

thecapdan opened this issue Aug 22, 2014 · 4 comments

Comments

@thecapdan
Copy link
Contributor

e.g. If we have an app has .js-style file that contains the old 'node,js' notation, then we should throw an exception, and maybe list the current valid styles that can be used.

@dchambers
Copy link
Contributor

This isn't quite as easy-picking as you might otherwise expect since we need a way to ask each plug-in what styles they recognize, then only throw an exception if none of the plug-ins recognize it.

@andy-berry-dev
Copy link
Member

@dchambers Agreed, but this issue is just to throw the exception so it is reasonably straightforward. If we don't already we need a separate issue to make the .js-style pluggable.

@andy-berry-dev
Copy link
Member

I've raised #929 to track making JS styles pluggable.

@dchambers
Copy link
Contributor

Just to be clear, the '.js-style' file is currently plug-able. So, in effect, you're proposing creating technical debt as a result of this issue that will mean it isn't, that we'll then fix at a later date in #929? If so, is there a particular reason why this issue is worthy of creating technical debt, since it's not something we normally do?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants