Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create-library command should be consistent with other commands #548

Closed
leggetter opened this issue Apr 18, 2014 · 1 comment
Closed

create-library command should be consistent with other commands #548

leggetter opened this issue Apr 18, 2014 · 1 comment

Comments

@leggetter
Copy link
Contributor

create-app reports the following requires a name and will auto generate a require-prefix based on the app name.

› ./brjs create-app    
creating plugins
performing node discovery
making plugins available via model
BladeRunnerJS version: v0.7-0-gff6e9cb, built: 14 April 2014 15:53 BST

Problem:
  Parameter 'new-app-name' is required.

Usage:
  brjs create-app <new-app-name> [<require-prefix>]

create-library requires a namespace to be specified:

› ./brjs create-library
creating plugins
performing node discovery
making plugins available via model
BladeRunnerJS version: v0.7-0-gff6e9cb, built: 14 April 2014 15:53 BST

Problem:
  Parameter 'new-library-name' is required.
  Parameter 'target-app-name' is required.
  Parameter 'library-namespace' is required.

Usage:
  brjs create-library <target-app-name> <new-library-name> <library-namespace>
  1. Should library-namespace be renamed to be require-prefix?
  2. library-namespace/require-prefix should be optional and if not present should default to the library name in the same way create-app does.
@andy-berry-dev
Copy link
Member

This is no longer an issue since the create-library command has been rewritten to allow both br and thirdparty library types and 'require-prefix' is no longer a command line option.

The help output for the command is:

Description:
  Create a new empty library within a given application.

Usage:
  brjs create-library <target-app-name> <new-library-name> [(-t|--type) <type>]

Help:
    <target-app-name>
        the application the new library will be created within

  <new-library-name>
        the name of the library that will be created

  [(-t|--type) <type>]
        (default: br)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants