Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App-deps command errors with some commonjs js-patches #1719

Open
thecapdan opened this issue Aug 11, 2016 · 0 comments
Open

App-deps command errors with some commonjs js-patches #1719

thecapdan opened this issue Aug 11, 2016 · 0 comments

Comments

@thecapdan
Copy link
Contributor

When we a cjs js-patch that needs to require the original class, the app-deps command fails with an error such as

java.lang.RuntimeException: Attempt to map '../../libs/javascript/br/presenter/node/Field.js' to '../../libs/javascript/br/presenter/node/Field.js'.

Example of offending patch:

var Field = require('br/presenter/node/Field');
var WritableProperty = require('br/presenter/property/WritableProperty');
var topiarist = require('topiarist');

function FieldPatch(vValue) {

    // PATCH START

    /**
     * A boolean property that is <code>true</code> if {@link #value} is waiting for validation, and <code>false</code> otherwise.
     * @type br.presenter.property.WritableProperty
     */
    this.pending = new WritableProperty(false);
    // PATCH END

    Field.call(this, vValue);
}

topiarist.extend(FieldPatch, Field);

module.exports = FieldPatch;
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant