Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the encoding of moment.js #1576

Open
thecapdan opened this issue Nov 5, 2015 · 3 comments
Open

Fix the encoding of moment.js #1576

thecapdan opened this issue Nov 5, 2015 · 3 comments
Labels
2 - Dev bug

Comments

@thecapdan
Copy link
Contributor

thecapdan commented Nov 5, 2015 •
edited
Loading

at some point this was checked in to our repo with the wrong encoding
@thecapdan thecapdan added the bug label Nov 5, 2015
@thecapdan thecapdan added this to the 1.2.0 milestone Nov 5, 2015
@andy-berry-dev andy-berry-dev modified the milestones: Current Focus, 1.2.0 Nov 16, 2015
@vmus
Copy link
Contributor

vmus commented Aug 15, 2016

Could someone please merge the momentjs-encoding branch?

@thecapdan thecapdan modified the milestones: 1.4.6, Current Focus Sep 1, 2016
@thecapdan
Copy link
Contributor Author

sorry @vmus , I had to revert this change as it caused issues on windows with some of our downstream projects. once i have found a solution that works for all supported OSs I will release the fix

@thecapdan
Copy link
Contributor Author

thecapdan commented Sep 2, 2016 •
edited
Loading

the following issue with js-test-driver prevents us from using momentjs with langs gabrielPeart/js-test-driver#454. Our downstream projects should be moving over to karma which will allow us to move over to momentjs with langs

@thecapdan thecapdan removed this from the 1.4.6 milestone Sep 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2 - Dev bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@andy-berry-dev @vmus @thecapdan