Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Closure Compiler to support ES5 code #1488

Open
dchambers opened this issue Aug 6, 2015 · 1 comment
Open

Allow Closure Compiler to support ES5 code #1488

dchambers opened this issue Aug 6, 2015 · 1 comment

Comments

@dchambers
Copy link
Contributor

Closure Compiler currently errors if you use certain ES5 features, like getter properties. By adding the following line of code at line 74 of ClosureMinifierPlugin:

options.setLanguageIn(LanguageMode.ECMASCRIPT5);

Closure Compiler will start to accept additional ES5 features.

It's my belief that ECMASCRIPT5 mode will not prevent people from using any ES3 features as there is a separate ECMASCRIPT5_STRICT mode that presumably adds these additional restrictions. Obviously we'll need some test(s) to verify this fix.

@dchambers dchambers added this to the 1.1 milestone Aug 6, 2015
@dchambers dchambers modified the milestones: Bugs & Docs, 1.1 Sep 15, 2015
@vmus
Copy link
Contributor

vmus commented May 18, 2016

Is this change still planned? Now that IE8 is no longer supported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants