improve magic numbers

Author: surbhi

src/bitmessagekivy/baseclass/common.py

@@ -43,6 +43,26 @@
     },
 }
 
+
+class ChipProperties:
+    """ChipProperties class for kivy UI"""
+    CENTER_X_ANDROID = 0.91
+    CENTER_X_OTHER = 0.94
+    CENTER_Y = 0.3
+    HEIGHT_DP = 18
+    RADIUS = [8]
+    TEXT_COLOR = (1, 1, 1, 1)
+    SIZE_HINT_ANDROID = (0.16, None)
+    SIZE_HINT_OTHER = (0.08, None)
+
+
+class BadgeProperties:
+    """BadgeProperties class for kivy UI"""
+    SIZE_ANDROID = [120, 140]
+    SIZE_OTHER = [64, 80]
+    FONT_SIZE = "11sp"
+
+
 DIALOG_WIDTH_ANDROID = 0.8
 DIALOG_WIDTH_OTHER = 0.55
 DIALOG_HEIGHT = 0.25

src/bitmessagekivy/baseclass/maildetail.py

@@ -22,7 +22,7 @@
 from pybitmessage.bitmessagekivy.baseclass.common import (
     avatar_image_first_letter, kivy_state_variables, show_time_history, toast,
     DIALOG_WIDTH_ANDROID, DIALOG_WIDTH_OTHER, DIALOG_HEIGHT, LONG_PRESS_DURATION,
-    DELETE_DELAY)
+    DELETE_DELAY, ChipProperties, BadgeProperties)
 from pybitmessage.bitmessagekivy.baseclass.popup import SenderDetailPopup
 from pybitmessage.bitmessagekivy.get_platform import platform
 from pybitmessage.helper_sql import sqlQuery
@@ -86,6 +86,8 @@ class MailDetail(Screen):  # pylint: disable=too-many-instance-attributes
     time_tag = StringProperty()
     avatar_image = StringProperty()
     no_subject = '(no subject)'
+    chipProperties = ChipProperties()
+    badgeProperties = BadgeProperties()
 
     def __init__(self, *args, **kwargs):
         """Initialize MailDetail screen."""

src/bitmessagekivy/kv/maildetail.kv

@@ -1,3 +1,6 @@
+#:set color_transparent (0,0,0,0) # transparent black
+#:set color_black (0,0,0,1) # black
+
 <MailDetail>:
     name: 'mailDetail'
     ScrollView:
@@ -15,7 +18,7 @@
                 font_style: 'H5'
                 theme_text_color: 'Primary'
                 _no_ripple_effect: True
-                long_press_time: 1
+                long_press_time: self.long_press_time
             TwoLineAvatarIconListItem:
                 id: subaft
                 text: app.tr._(root.from_addr)
@@ -24,20 +27,23 @@
                 on_press: root.detailed_popup()
                 BadgeText:
                     size_hint:(None, None)
-                    size:[120, 140] if app.app_platform == 'android' else [64, 80]
+                    size: root.badgeProperties.SIZE_ANDROID if app.app_platform == 'android' else root.badgeProperties.SIZE_OTHER
                     text: app.tr._(root.time_tag)
                     halign:'center'
                     font_style:'Caption'
                     pos_hint: {'center_y': .8}
                     _txt_right_pad: dp(70)
-                    font_size: '11sp'
+                    font_size: root.badgeProperties.FONT_SIZE
                 MDChip:
-                    size_hint: (.16 if app.app_platform == 'android' else .08 , None)
+                    size_hint: root.chipProperties.SIZE_HINT_ANDROID if app.app_platform == 'android' else root.chipProperties.SIZE_HINT_OTHER
                     text: app.tr._(root.page_type)
                     icon: ''
-                    text_color: (1,1,1,1)
-                    pos_hint: {'center_x': .91 if app.app_platform == 'android' else .95, 'center_y': .3}
-                    radius: [8]
+                    text_color: root.chipProperties.TEXT_COLOR
+                    pos_hint: {
+                        'center_x': root.chipProperties.CENTER_X_ANDROID if app.app_platform == 'android' else root.chipProperties.CENTER_X_OTHER,
+                        'center_y': root.chipProperties.CENTER_Y
+                    }
+                    radius: root.chipProperties.RADIUS
                     height: self.parent.height/4
                 AvatarSampleWidget:
                     source: root.avatar_image
@@ -54,18 +60,18 @@
                 text: root.message
                 multiline: True
                 readonly: True
-                line_color_normal: [0,0,0,0]
-                _current_line_color: [0,0,0,0]
-                line_color_focus: [0,0,0,0]
+                line_color_normal: color_transparent
+                _current_line_color: color_transparent
+                line_color_focus: color_transparent
                 markup: True
                 font_size: '15sp'
                 canvas.before:
                     Color:
-                        rgba: (0,0,0,1)
+                        rgba: color_black
     Loader:
 
 
 <MyMDTextField@MDTextField>:
     canvas.before:
         Color:
-            rgba: (0,0,0,1)
+            rgba: color_black