code-quality: Update code quality in addressbook

Author: surbhi

src/bitmessagekivy/baseclass/addressbook.py

@@ -13,10 +13,7 @@
 import logging
 from functools import partial
 
-from kivy.properties import (
-    ListProperty,
-    StringProperty
-)
+from kivy.properties import ListProperty, StringProperty
 from kivy.uix.screenmanager import Screen
 from kivy.app import App
 
@@ -32,9 +29,17 @@
 
 logger = logging.getLogger('default')
 
+INITIAL_SCROLL_POSITION = 1.0
+SCROLL_THRESHOLD = -0.0
+SCROLL_RESET_POSITION = 0.06
+INITIAL_LOAD_COUNT = 20
+ADDRESS_INCREMENT = 5
+POPUP_WIDTH_ANDROID = 0.9
+POPUP_WIDTH_OTHER = 0.8
+
 
 class AddressBook(Screen, HelperAddressBook):
-    """AddressBook Screen class for kivy Ui"""
+    """AddressBook Screen class for kivy UI"""
 
     queryreturn = ListProperty()
     has_refreshed = True
@@ -45,77 +50,74 @@ class AddressBook(Screen, HelperAddressBook):
 
     def __init__(self, *args, **kwargs):
         """Getting AddressBook Details"""
-        super(AddressBook, self).__init__(*args, **kwargs)
+        super().__init__(*args, **kwargs)  # pylint: disable=missing-super-argument
         self.addbook_popup = None
         self.kivy_state = kivy_state_variables()
 
     def loadAddresslist(self, account, where="", what=""):
-        """Clock Schdule for method AddressBook"""
+        """Load address list with optional search filters"""
         if self.kivy_state.searching_text:
-            self.ids.scroll_y.scroll_y = 1.0
+            self.ids.scroll_y.scroll_y = INITIAL_SCROLL_POSITION
             where = ['label', 'address']
             what = self.kivy_state.searching_text
+
         xAddress = ''
         self.ids.tag_label.text = ''
-        self.queryreturn = kivy_helper_search.search_sql(
-            xAddress, account, "addressbook", where, what, False)
-        self.queryreturn = [obj for obj in reversed(self.queryreturn)]
+        self.queryreturn = list(reversed(
+            kivy_helper_search.search_sql(xAddress, account, "addressbook", where, what, False)
+        ))
+
         if self.queryreturn:
             self.ids.tag_label.text = 'Address Book'
             self.has_refreshed = True
-            self.set_mdList(0, 20)
+            self.set_mdList(0, INITIAL_LOAD_COUNT)
             self.ids.scroll_y.bind(scroll_y=self.check_scroll_y)
         else:
             self.ids.ml.add_widget(empty_screen_label(self.label_str, self.no_search_res_found))
 
     def set_mdList(self, start_index, end_index):
-        """Creating the mdList"""
+        """Create the mdList"""
         for item in self.queryreturn[start_index:end_index]:
-            message_row = SwipeToDeleteItem(
-                text=item[0],
-            )
+            message_row = SwipeToDeleteItem(text=item[0])
             listItem = message_row.ids.content
             listItem.secondary_text = item[1]
             listItem.theme_text_color = "Custom"
             listItem.text_color = ThemeClsColor
             image = os.path.join(
-                self.kivy_state.imageDir, "text_images", "{}.png".format(avatar_image_first_letter(item[0].strip()))
+                self.kivy_state.image_dir, "text_images",
+                f"{avatar_image_first_letter(item[0].strip())}.png"  # noqa: E999
             )
             message_row.ids.avater_img.source = image
-            listItem.bind(on_release=partial(
-                self.addBook_detail, item[1], item[0], message_row))
+            listItem.bind(on_release=partial(self.addBook_detail, item[1], item[0], message_row))
             message_row.ids.delete_msg.bind(on_press=partial(self.delete_address, item[1]))
             self.ids.ml.add_widget(message_row)
 
-    def check_scroll_y(self, instance, somethingelse):
-        """Load data on scroll"""
-        if self.ids.scroll_y.scroll_y <= -0.0 and self.has_refreshed:
-            self.ids.scroll_y.scroll_y = 0.06
+    def check_scroll_y(self, instance, _):
+        """Load more data on scroll down"""
+        if self.ids.scroll_y.scroll_y <= SCROLL_THRESHOLD and self.has_refreshed:
+            self.ids.scroll_y.scroll_y = SCROLL_RESET_POSITION
             exist_addresses = len(self.ids.ml.children)
             if exist_addresses != len(self.queryreturn):
                 self.update_addressBook_on_scroll(exist_addresses)
-            self.has_refreshed = (
-                True if exist_addresses != len(self.queryreturn) else False
-            )
+            self.has_refreshed = exist_addresses != len(self.queryreturn)
 
     def update_addressBook_on_scroll(self, exist_addresses):
-        """Load more data on scroll down"""
-        self.set_mdList(exist_addresses, exist_addresses + 5)
+        """Load more data on scroll"""
+        self.set_mdList(exist_addresses, exist_addresses + ADDRESS_INCREMENT)
 
     @staticmethod
     def refreshs(*args):
         """Refresh the Widget"""
 
-    # @staticmethod
     def addBook_detail(self, address, label, instance, *args):
-        """Addressbook details"""
+        """Display Addressbook details"""
         if instance.state == 'closed':
             instance.ids.delete_msg.disabled = True
             if instance.open_progress == 0.0:
                 obj = SavedAddressDetailPopup()
                 self.address_label = obj.address_label = label
                 self.address = obj.address = address
-                width = .9 if platform == 'android' else .8
+                width = POPUP_WIDTH_ANDROID if platform == 'android' else POPUP_WIDTH_OTHER
                 self.addbook_popup = self.address_detail_popup(
                     obj, self.send_message_to, self.update_addbook_label,
                     self.close_pop, width)
@@ -125,40 +127,42 @@ def addBook_detail(self, address, label, instance, *args):
             instance.ids.delete_msg.disabled = False
 
     def delete_address(self, address, instance, *args):
-        """Delete inbox mail from inbox listing"""
+        """Delete address from the address book"""
         self.ids.ml.remove_widget(instance.parent.parent)
-        # if len(self.ids.ml.children) == 0:
-        if self.ids.ml.children is not None:
+        if self.ids.ml.children:
             self.ids.tag_label.text = ''
-        sqlExecute(
-            "DELETE FROM  addressbook WHERE address = ?", address)
+        sqlExecute("DELETE FROM addressbook WHERE address = ?", address)
         toast('Address Deleted')
 
     def close_pop(self, instance):
-        """Pop is Canceled"""
+        """Cancel and close the popup"""
         self.addbook_popup.dismiss()
         toast('Canceled')
 
     def update_addbook_label(self, instance):
-        """Updating the label of address book address"""
+        """Update the label of the address book"""
         address_list = kivy_helper_search.search_sql(folder="addressbook")
         stored_labels = [labels[0] for labels in address_list]
         add_dict = dict(address_list)
         label = str(self.addbook_popup.content_cls.ids.add_label.text)
+
         if label in stored_labels and self.address == add_dict[label]:
             stored_labels.remove(label)
+
         if label and label not in stored_labels:
             sqlExecute("""
                 UPDATE addressbook
                 SET label = ?
                 WHERE address = ?""", label, self.addbook_popup.content_cls.address)
-            App.get_running_app().root.ids.id_addressbook.ids.ml.clear_widgets()
-            App.get_running_app().root.ids.id_addressbook.loadAddresslist(None, 'All', '')
+
+            app = App.get_running_app()
+            app.root.ids.id_addressbook.ids.ml.clear_widgets()
+            app.root.ids.id_addressbook.loadAddresslist(None, 'All', '')
             self.addbook_popup.dismiss()
             toast('Saved')
 
     def send_message_to(self, instance):
-        """Method used to fill to_address of composer autofield"""
+        """Fill the to_address of the composer autofield"""
         App.get_running_app().set_navbar_for_composer()
         self.compose_message(None, self.address)
         self.addbook_popup.dismiss()

src/bitmessagekivy/baseclass/addressbook_widgets.py

@@ -1,50 +1,64 @@
-# pylint: disable=no-member, too-many-arguments, too-few-public-methods
-"""
-Addressbook widgets are here.
-"""
+# pylint: disable=no-member, too-many-arguments, too-few-public-methods, no-init
+
+"""Addressbook widgets are here."""
 
 from kivy.app import App
 from kivymd.uix.button import MDRaisedButton
 from kivymd.uix.dialog import MDDialog
 
+POPUP_HEIGHT_PROPORTION = 0.25
+
 
 class HelperAddressBook(object):
-    """Widget used in Addressbook are here"""
+    """Widget utilities for Addressbook."""
 
     @staticmethod
     def address_detail_popup(obj, send_message, update_address, close_popup, width):
-        """This function shows the address's details and opens the popup."""
-        show_dialogue = MDDialog(
+        """
+        Shows address details in a popup with clear actions.
+
+        Args:
+            obj: The widget containing the address details to display.
+            send_message: The function to call when the "Send message" button is pressed.
+            update_address: The function to call when the "Save" button is pressed.
+            close_popup: The function to call when the "Cancel" button is pressed or the popup is closed.
+            width: The desired width of the popup as a proportion of the screen.
+        """
+
+        buttons = [
+            MDRaisedButton(text="Send message", on_release=send_message),
+            MDRaisedButton(text="Update Address", on_release=update_address),
+            MDRaisedButton(text="Cancel", on_release=close_popup),
+        ]
+
+        return MDDialog(
             type="custom",
-            size_hint=(width, .25),
+            size_hint=(width, POPUP_HEIGHT_PROPORTION),
             content_cls=obj,
-            buttons=[
-                MDRaisedButton(
-                    text="Send message to",
-                    on_release=send_message,
-                ),
-                MDRaisedButton(
-                    text="Save",
-                    on_release=update_address,
-                ),
-                MDRaisedButton(
-                    text="Cancel",
-                    on_release=close_popup,
-                ),
-            ],
+            buttons=buttons,
         )
-        return show_dialogue
 
     @staticmethod
     def compose_message(from_addr=None, to_addr=None):
-        """This UI independent method for message sending to reciever"""
-        window_obj = App.get_runnint_app().root.ids
-        if to_addr:
-            window_obj.id_create.children[1].ids.txt_input.text = to_addr
-        if from_addr:
-            window_obj.id_create.children[1].ids.txt_input.text = from_addr
-        window_obj.id_create.children[1].ids.ti.text = ''
-        window_obj.id_create.children[1].ids.composer_dropdown.text = 'Select'
-        window_obj.id_create.children[1].ids.subject.text = ''
-        window_obj.id_create.children[1].ids.body.text = ''
-        window_obj.scr_mngr.current = 'create'
+        """
+        Composes a new message (UI-independent).
+
+        Args:
+            from_addr (str, optional): The address to set in the "From" field. Defaults to None.
+            to_addr (str, optional): The address to set in the "To" field. Defaults to None.
+        """
+
+        app = App.get_running_app()
+
+        ids = app.root.ids
+        create_screen = ids.id_create.children[1].ids
+
+        # Reset fields
+        create_screen.txt_input.text = to_addr if to_addr else from_addr
+        create_screen.ti.text = ""
+        create_screen.composer_dropdown.text = "Select"
+        create_screen.subject.text = ""
+        create_screen.body.text = ""
+
+        # Navigate to create screen
+        ids.scr_mngr.current = "create"