Skip to content

Add ⚡️to Private Key Management - Multi-key #564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 17, 2021
Merged

Add ⚡️to Private Key Management - Multi-key #564

merged 2 commits into from
Nov 17, 2021

Conversation

@danielnordh
Copy link
Contributor

@danielnordh danielnordh commented Nov 15, 2021 •
edited
Loading

As discussed in #547

Adds tip about Lightning node incompatibility
Adds con
Adds when not to use

Preview: https://deploy-preview-564--sad-borg-390916.netlify.app/guide/private-key-management/multi-key/

@danielnordh danielnordh mentioned this pull request Nov 15, 2021
Closed
46 tasks
@GBKS GBKS added this to the Milestone #10 milestone Nov 15, 2021
@GBKS GBKS added the Copy Task is about improving text. label Nov 15, 2021
@GBKS GBKS added the How it works Referring to the How it works section. label Nov 15, 2021
pavlenex
pavlenex previously approved these changes Nov 16, 2021
View reviewed changes
Copy link
Contributor

@pavlenex pavlenex left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

afaik multi-key isn't yet possible, so imo we're good to merge this one, since I haven't explored the world of multi-keys and LN, would appreciate some 👀/approval from @Bosch-0 or @sbddesign who may have explored this more in depth so we can proceed with merging..

@pavlenex pavlenex requested a review from sbddesign November 16, 2021 09:09
GBKS
GBKS reviewed Nov 16, 2021
View reviewed changes
@Bosch-0
Copy link
Collaborator

Bosch-0 commented Nov 16, 2021

Well a payment channel is a multi-key contract - could add some details around that and how multi-keys is the bedrock of the Lightning network.

@danielnordh
Copy link
Contributor Author

danielnordh commented Nov 16, 2021

Well a payment channel is a multi-key contract - could add some details around that and how multi-keys is the bedrock of the Lightning network.

Since the context here is private key schemes for wallets, and the function of Lightning is described elsewhere I think it's better to not mention that here.

Bosch-0
Bosch-0 approved these changes Nov 17, 2021
View reviewed changes
Copy link
Collaborator

@Bosch-0 Bosch-0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nothing else to add on my side

@pavlenex pavlenex merged commit d41164e into master Nov 17, 2021
@pavlenex pavlenex mentioned this pull request Nov 17, 2021
Closed
@danielnordh danielnordh deleted the feature/private-key-management-multikey-updates branch December 2, 2021 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GBKS GBKS GBKS left review comments

@sbddesign sbddesign Awaiting requested review from sbddesign

+2 more reviewers

@pavlenex pavlenex pavlenex approved these changes

@Bosch-0 Bosch-0 Bosch-0 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@danielnordh danielnordh

Labels

Copy Task is about improving text. How it works Referring to the How it works section.

Projects

None yet

Milestone

Milestone #10

Development

Successfully merging this pull request may close these issues.

5 participants

@danielnordh @Bosch-0 @GBKS @pavlenex