Header Theme Bridging Bitcoin - Images Update #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the images for the "Bridging Bitcoin" theme. Half of the design has a transparent background, so I switched the backgroundImageColor to the bitcoin orange. Hope that solves it.
ghost
marked this pull request as ready for review
JPG version of those header banners are not needed if we only use the PNGs. PNGs are around 60% smaller now (used ImageOptim).
|
@AlexaAker thank you. I committed some minor tweaks, optimizing the file size of PNGs (2/3 smaller now) and removing the unused JPGs. All set to be merged, IMHO. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added four higher quality images, following @GBKS setup.
Half of the image has a transparent background, where the bitcoin orange should be. This is to make sure to color-match the bitcoin orange on the entire header area, just in case the image's orange background could vary in tone. I've modified the backgroundImageColor to bitcoin orange to address this.