Skip to content

Conversation

@danielnordh
Copy link
Contributor

@danielnordh danielnordh commented Oct 14, 2021

As outlined in #519, updates this page for Lightning.
Also includes some shortening and readability updates.

Preview: https://deploy-preview-524--sad-borg-390916.netlify.app/guide/onboarding/restoring-a-wallet/

@GBKS GBKS added Copy Task is about improving text. Onboarding labels Oct 15, 2021
@GBKS GBKS linked an issue Oct 15, 2021 that may be closed by this pull request
Copy link
Contributor

@GBKS GBKS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also looks good. A few thoughts:

  • Should we note that this backup does not include user data (contacts, transaction notes, etc)
  • Are there any other UX recommendations we can add? Any tips for copy, letting users ensure everything is there post import, etc.
  • Can you think of ways we can improve the visuals on this page? We could show an example screen for each of the options.

danielnordh and others added 9 commits October 18, 2021 10:48
@danielnordh
Copy link
Contributor Author

  • Should we note that this backup does not include user data (contacts, transaction notes, etc)
  • Are there any other UX recommendations we can add? Any tips for copy, letting users ensure everything is there post import, etc.

Added note about what's not restored 31f2cc8, and recommendation bubble c03962c

Copy link
Contributor

@pavlenex pavlenex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the only thing that bothers me is:

This is particularly true for a wallet holding bitcoin on the Lightning network, and restoring should be done with the application originally used.

I think we should recommend that wallets should strive for vendor independency and interoperability.

Where:

Vendor independency: Can you restore the client w/o the vendor (backup data doesn't reside on vendor servers)?
Interoperability: the ability to restore in a different environment.

But I personally am not familiar with best practice neither I'm sure the protocol matured for this problem in particular.

Co-authored-by: Pavlenex <pavlenex@btcpayserver.org>
@danielnordh
Copy link
Contributor Author

Think this is good to merge now.
Any following changes can be a new PR.

Copy link
Contributor

@pavlenex pavlenex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. My earlier comment about backups aren't really blocker since Daniel has asked in LDK slack and it seems unique backup methods are unlikely to happen between implementations.

@pavlenex pavlenex merged commit 3a8ce3c into master Oct 19, 2021
@danielnordh danielnordh deleted the feature/onboarding-first-use-lightning-updates branch December 2, 2021 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Copy Task is about improving text.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add ⚡️ content to Onboarding > Restoring a wallet

6 participants