Added ⚡ content to Getting Started > Hardware overview
#476
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GBKS
reviewed
Sep 16, 2021
GBKS
reviewed
Sep 16, 2021
GBKS
reviewed
Sep 16, 2021
GBKS
reviewed
Sep 16, 2021
GBKS
reviewed
Sep 16, 2021
GBKS
reviewed
Sep 16, 2021
GBKS
reviewed
Sep 16, 2021
GBKS
reviewed
Sep 16, 2021
Contributor
|
Looks great, this is a good revision. Just had a few minor nit-picky things, after that I think it's ready to go. |
Co-authored-by: Christoph Ono <chri@sto.ph>
Co-authored-by: Christoph Ono <chri@sto.ph>
Co-authored-by: Christoph Ono <chri@sto.ph>
Co-authored-by: Christoph Ono <chri@sto.ph>
Co-authored-by: Christoph Ono <chri@sto.ph>
Co-authored-by: Christoph Ono <chri@sto.ph>
Co-authored-by: Christoph Ono <chri@sto.ph>
Co-authored-by: Christoph Ono <chri@sto.ph>
Bosch-0
commented
Sep 17, 2021
Collaborator
Author
Bosch-0
left a comment
Bosch-0
left a comment
There was a problem hiding this comment.
Thanks for that :)
GBKS
reviewed
Sep 17, 2021
GBKS
reviewed
Sep 17, 2021
GBKS
reviewed
Sep 17, 2021
GBKS
reviewed
Sep 17, 2021
GBKS
reviewed
Sep 17, 2021
GBKS
requested changes
Sep 17, 2021
Contributor
GBKS
left a comment
GBKS
left a comment
There was a problem hiding this comment.
Had a few super minor tweaks after reading through the page again. Otherwise, ready to go.
46 tasks
pavlenex
reviewed
Sep 17, 2021
Contributor
pavlenex
left a comment
pavlenex
left a comment
There was a problem hiding this comment.
Great work @Bosch-0, comparing it to the previous page, you managed to iron out quite a few things. I only have two concerns:
- A claim that a hardware wallet cannot leak sensitive data in one of the paragraphs, the paragraph explains this more accurately.
- A claim that you can run a lightning node on a smatphone, I am not really sure about this at this stage.
Co-authored-by: Christoph Ono <chri@sto.ph>
Co-authored-by: Christoph Ono <chri@sto.ph>
Co-authored-by: Christoph Ono <chri@sto.ph>
Co-authored-by: Christoph Ono <chri@sto.ph>
Co-authored-by: Pavlenex <pavle@pavle.org>
pavlenex
approved these changes
Sep 20, 2021
pavlenex
approved these changes
Sep 20, 2021
Contributor
|
@GBKS review and approve, can't merge since the |
GBKS
approved these changes
Sep 20, 2021
Contributor
GBKS
left a comment
GBKS
left a comment
There was a problem hiding this comment.
Thanks for addressing all the feedback. Looks really good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding Lightning content to the hardware overview page, solves #466
Deploy: https://deploy-preview-476--sad-borg-390916.netlify.app/guide/getting-started/hardware/