-
Notifications
You must be signed in to change notification settings - Fork 110
Create unified Bitcoin design principles page #144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Solid list and principles. Some early light feedback.
Co-authored-by: Christoph Ono <chri@sto.ph>
…/Guide into feature/principles
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did a final look at the content in-depth. Structure-wise, great work, and I think you included the most important principles and emphasized their importance.
I've suggested a few minor typos and grammar-related fixes I've noticed, as well as 2-3 attempts to simplify the structure of the sentence, which is up to you to accept or ignore, it's just a personal preference.
Co-authored-by: Pavlenex <pavlenex@btcpayserver.org>
Co-authored-by: Pavlenex <pavlenex@btcpayserver.org>
Co-authored-by: Pavlenex <pavlenex@btcpayserver.org>
Co-authored-by: Pavlenex <pavlenex@btcpayserver.org>
Co-authored-by: Pavlenex <pavlenex@btcpayserver.org>
Co-authored-by: Pavlenex <pavlenex@btcpayserver.org>
Co-authored-by: Pavlenex <pavlenex@btcpayserver.org>
Co-authored-by: Pavlenex <pavlenex@btcpayserver.org>
Co-authored-by: Pavlenex <pavlenex@btcpayserver.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK.
This one is good to get merged IMO 🚀
tACK. Two small follow-up tasks I can think of:
|
@danielnordh @GBKS For the follow-up tasks, if you'd like we can open a separate issue to keep a track of it. 🚀 🚀 |
Adds new page for unified principles following issue #116.
Todo: