node/chainstate: Decouple from ArgsManager

Summary:
```
...instead pass in only the necessary information
```

Partial backport of [[bitcoin/bitcoin#23280 | core#23280]]:
bitcoin/bitcoin@c7a5c46

Test Plan:
  ninja all check-all

Reviewers: #bitcoin_abc, PiRK

Reviewed By: #bitcoin_abc, PiRK

Differential Revision: https://reviews.bitcoinabc.org/D12565

Author: dongcarl

src/init.cpp

@@ -2465,9 +2465,11 @@ bool AppInitMain(Config &config, RPCServer &rpcServer,
 
         const int64_t load_block_index_start_time = GetTimeMillis();
 
-        auto rv = LoadChainstate(fReset, chainman, node, fPruneMode, config,
-                                 args, fReindexChainState, nBlockTreeDBCache,
-                                 nCoinDBCache, nCoinCacheUsage);
+        auto rv = LoadChainstate(
+            fReset, chainman, node, fPruneMode, config, fReindexChainState,
+            nBlockTreeDBCache, nCoinDBCache, nCoinCacheUsage,
+            args.GetIntArg("-checkblocks", DEFAULT_CHECKBLOCKS),
+            args.GetIntArg("-checklevel", DEFAULT_CHECKLEVEL));
 
         if (rv.has_value()) {
             switch (rv.value()) {

src/node/chainstate.cpp

@@ -16,9 +16,10 @@
 
 std::optional<ChainstateLoadingError>
 LoadChainstate(bool fReset, ChainstateManager &chainman, NodeContext &node,
-               bool fPruneMode_, const Config &config, const ArgsManager &args,
-               bool fReindexChainState, int64_t nBlockTreeDBCache,
-               int64_t nCoinDBCache, int64_t nCoinCacheUsage) {
+               bool fPruneMode_, const Config &config, bool fReindexChainState,
+               int64_t nBlockTreeDBCache, int64_t nCoinDBCache,
+               int64_t nCoinCacheUsage, unsigned int check_blocks,
+               unsigned int check_level) {
     const CChainParams &chainparams = config.GetChainParams();
 
     auto is_coinsview_empty =
@@ -147,9 +148,7 @@ LoadChainstate(bool fReset, ChainstateManager &chainman, NodeContext &node,
                 if (!is_coinsview_empty(chainstate)) {
                     uiInterface.InitMessage(
                         _("Verifying blocks...").translated);
-                    if (fHavePruned &&
-                        args.GetIntArg("-checkblocks", DEFAULT_CHECKBLOCKS) >
-                            MIN_BLOCKS_TO_KEEP) {
+                    if (fHavePruned && check_blocks > MIN_BLOCKS_TO_KEEP) {
                         LogPrintf(
                             "Prune: pruned datadir may not have more than %d "
                             "blocks; only checking available blocks\n",
@@ -162,11 +161,9 @@ LoadChainstate(bool fReset, ChainstateManager &chainman, NodeContext &node,
                         return ChainstateLoadingError::ERROR_BLOCK_FROM_FUTURE;
                     }
 
-                    if (!CVerifyDB().VerifyDB(
-                            *chainstate, config, chainstate->CoinsDB(),
-                            args.GetIntArg("-checklevel", DEFAULT_CHECKLEVEL),
-                            args.GetIntArg("-checkblocks",
-                                           DEFAULT_CHECKBLOCKS))) {
+                    if (!CVerifyDB().VerifyDB(*chainstate, config,
+                                              chainstate->CoinsDB(),
+                                              check_level, check_blocks)) {
                         return ChainstateLoadingError::ERROR_CORRUPTED_BLOCK_DB;
                     }
                 }

src/node/chainstate.h

@@ -8,7 +8,6 @@
 #include <cstdint>
 #include <optional>
 
-class ArgsManager;
 struct bilingual_str;
 class Config;
 class ChainstateManager;
@@ -58,8 +57,9 @@ enum class ChainstateLoadingError {
  */
 std::optional<ChainstateLoadingError>
 LoadChainstate(bool fReset, ChainstateManager &chainman, NodeContext &node,
-               bool fPruneMode, const Config &config, const ArgsManager &args,
-               bool fReindexChainState, int64_t nBlockTreeDBCache,
-               int64_t nCoinDBCache, int64_t nCoinCacheUsage);
+               bool fPruneMode, const Config &config, bool fReindexChainState,
+               int64_t nBlockTreeDBCache, int64_t nCoinDBCache,
+               int64_t nCoinCacheUsage, unsigned int check_blocks,
+               unsigned int check_level);
 
 #endif // BITCOIN_NODE_CHAINSTATE_H