Skip to content

Commit 449d01c

Browse files
KevinMusgraveFabcien
authored andcommitted
refactor, miner: Delete call to UpdatePackagesForAdded at beginning of addPackageTxs
Summary: ``` In CreateNewBlock (in miner.cpp), inBlock is cleared before addPackageTxs, so inBlock will be empty in the first call to UpdatePackagesForAdded ``` Since this is the only callsite, there is no change in behavior. Backport of [[bitcoin/bitcoin#24934 | core#24934]]. Depends on D12954. Test Plan: ninja all check-all Reviewers: #bitcoin_abc, sdulfari Reviewed By: #bitcoin_abc, sdulfari Differential Revision: https://reviews.bitcoinabc.org/D12955
1 parent ce0b1b9 commit 449d01c

File tree

1 file changed

+0
-4
lines changed

1 file changed

+0
-4
lines changed

src/node/miner.cpp

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -397,10 +397,6 @@ void BlockAssembler::addPackageTxs(int &nPackagesSelected,
397397
// Keep track of entries that failed inclusion, to avoid duplicate work.
398398
CTxMemPool::setEntries failedTx;
399399

400-
// Start by adding all descendants of previously added txs to mapModifiedTx
401-
// and modifying them for their already included ancestors.
402-
UpdatePackagesForAdded(inBlock, mapModifiedTx);
403-
404400
CTxMemPool::indexed_transaction_set::index<ancestor_score>::type::iterator
405401
mi = m_mempool.mapTx.get<ancestor_score>().begin();
406402
CTxMemPool::txiter iter;

0 commit comments

Comments
 (0)