u2fhid: Write as many bytes as possible #123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NickeZ
force-pushed
the
nickez/write-all-u2fhid-packets
branch
6 times, most recently
from
67c394b to
baf52a8
Compare
benma
approved these changes
May 8, 2025
communication/u2fhid/u2fhid.go
Outdated
| out.Write(readBuffer.Next(contPayloadSize)) | ||
| } | ||
|
|
||
| // Make out buffer multiple of writeReportSize bytes |
There was a problem hiding this comment.
I don't really understand this comment. How about Pad to a multiple of 64?
To be more efficient multiple u2fhid packets are written simultaneously if possible
NickeZ
force-pushed
the
nickez/write-all-u2fhid-packets
branch
from
bb9d96c to
8e05da0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be more efficient multiple u2fhid packets are written simultaneously if possible
Should be carefully tested on all platforms. A good test is the firmware upgrade as it for sure tries to send larger packets.