frontend: convert utils/equal to typescript #3344
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thisconnect
force-pushed
the
frontend-utilsequal-in-typescript
branch
3 times, most recently
from
23a4c21 to
b85f8d1
Compare
Simplifying so that TypeScript better understand the code and we can change from any to unknown in the future.
Using `unknown` enforces type safety by requiring explicit type checks or assertions before performing operations on the values. Also updated `Object.keys` usage with a more precise type assertion to satisfy TypeScript's stricter checks when working with `unknown`. This version now also supports date and regexp.
thisconnect
force-pushed
the
frontend-utilsequal-in-typescript
branch
from
b85f8d1 to
b642aef
Compare
Added various tests with some llm help.
thisconnect
changed the title
Fixed failing test introduced in last commit and correctly handle sparse arrays.
thisconnect
force-pushed
the
frontend-utilsequal-in-typescript
branch
from
639104e to
5ee9762
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.