fix clippy warnings

Author: benma

bitbox-bridge/src/main.rs

@@ -86,7 +86,7 @@ fn main() -> Result<(), Box<dyn std::error::Error>> {
         }
     };
 
-    let addr = SocketAddr::new("127.0.0.1".parse()?, u16::from_str_radix(port, 10)?);
+    let addr = SocketAddr::new("127.0.0.1".parse()?, port.parse::<u16>()?);
 
     println!("listening on http://{}", addr);
     let server = web::create(usb_devices, notify_tx, addr);

bitbox-bridge/src/usb.rs

@@ -105,7 +105,7 @@ impl UsbDevices {
                 d.insert(
                     "path".into(),
                     percent_encoding::utf8_percent_encode(
-                        &device.0,
+                        device.0,
                         percent_encoding::NON_ALPHANUMERIC,
                     )
                     .to_string(),
@@ -171,19 +171,18 @@ impl UsbDevices {
                         continue;
                     }
                 };
-                let product = product_string.as_ref();
                 seen.push(path.to_string());
                 match devices_guard.entry(path.to_string()) {
                     Entry::Occupied(_) => (),
                     Entry::Vacant(v) => {
                         info!("Found BitBox02 at {}!", path);
-                        v.insert(DeviceEntry::new(&product));
+                        v.insert(DeviceEntry::new(product_string));
                     }
                 }
             }
         }
         // Remove all devices that wasn't seen
-        devices_guard.retain(|k, _| seen.contains(&k));
+        devices_guard.retain(|k, _| seen.contains(k));
         Ok(())
     }
 

bitbox-bridge/src/web.rs

@@ -205,7 +205,7 @@ pub fn create(
                 if let Some(origin) = origin {
                     match origin.host() {
                         Some(host) => {
-                            if !is_valid_origin(&host) {
+                            if !is_valid_origin(host) {
                                 warn!("Not whitelisted origin tried to connect: {}", host);
                                 return Err(warp::reject::custom(WebError::NonLocalIp));
                             }

hidapi-async/src/lib.rs

@@ -68,7 +68,7 @@ pub struct Device {
 impl Clone for Device {
     fn clone(&self) -> Self {
         Device {
-            inner: self.inner.as_ref().map(|dev| Arc::clone(&dev)),
+            inner: self.inner.as_ref().map(|dev| Arc::clone(dev)),
         }
     }
 }