Add SimpleQueryString As Alternate Syntax For Simple_Query_String #162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: GabeFernandez310 <gabrielf@bitquilltech.com>
Signed-off-by: GabeFernandez310 <gabrielf@bitquilltech.com>
Signed-off-by: GabeFernandez310 <gabrielf@bitquilltech.com>
Codecov Report
@@ Coverage Diff @@
## integ-add-legacy-syntax-for-simple_query_string-function #162 +/- ##
===========================================================================================
Coverage ? 95.71%
Complexity ? 3351
===========================================================================================
Files ? 337
Lines ? 9117
Branches ? 672
===========================================================================================
Hits ? 8726
Misses ? 334
Partials ? 57
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
GabeFernandez310
changed the title
Signed-off-by: GabeFernandez310 <gabrielf@bitquilltech.com>
Yury-Fridlyand
requested review from
GumpacG,
MaxKsyunz,
MitchellGale,
Yury-Fridlyand,
acarbonetto,
forestmvey and
margarit-h
Yury-Fridlyand
approved these changes
Nov 11, 2022
| multiFieldRelevanceFunctionName | ||
| : MULTI_MATCH | ||
| | SIMPLE_QUERY_STRING | ||
| | SIMPLEQUERYSTRING |
There was a problem hiding this comment.
Legacy engine never had such syntax (with square brackets []): func(['field']...)
There was a problem hiding this comment.
This is correct. For whatever reason, it doesn't appear at that simplequerystring was included.
We should just close this PR without merging... I don't think it's needed.
acarbonetto
reviewed
Nov 14, 2022
| ``simplequerystring([field_expression+], query_expression[, option=<option_value>]*)`` | ||
|
|
||
| The simplequerystring function maps to the simple_query_string query used in search engine, to return the documents that match a provided text, number, date or boolean value with a given field or fields. This is an alternate syntax for `simple_query_string`_ | ||
| The **^** lets you *boost* certain fields. Boosts are multipliers that weigh matches in one field more heavily than matches in other fields. The syntax allows to specify the fields in double quotes, single quotes, in backtick or even without any wrap. All fields search using star ``"*"`` is also available (star symbol should be wrapped). The weight is optional and should be specified using after the field name, it could be delimeted by the `caret` character or by whitespace. Please, refer to examples below: |
|
|
||
| ``simplequerystring([field_expression+], query_expression[, option=<option_value>]*)`` | ||
|
|
||
| The simplequerystring function maps to the simple_query_string query used in search engine, to return the documents that match a provided text, number, date or boolean value with a given field or fields. This is an alternate syntax for `simple_query_string`_ |
There was a problem hiding this comment.
please mention that this is added for backwards compatibility
| multiFieldRelevanceFunctionName | ||
| : MULTI_MATCH | ||
| | SIMPLE_QUERY_STRING | ||
| | SIMPLEQUERYSTRING |
There was a problem hiding this comment.
This is correct. For whatever reason, it doesn't appear at that simplequerystring was included.
We should just close this PR without merging... I don't think it's needed.
GabeFernandez310
deleted the
dev-add-legacy-syntax-for-simple_query_string-function
branch
andy-k-improving
pushed a commit
that referenced
this pull request
Nov 16, 2024
* Add geojson support for XYPoint Signed-off-by: Heemin Kim <heemin@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds
simplequerystringas alternate syntax for thesimple_query_stringfunction which currently exists in the SQL plugin.Issues Resolved
AOS-765
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.