-
Notifications
You must be signed in to change notification settings - Fork 0
/
Copy pathretro
37 lines (25 loc) · 1.16 KB
/
retro
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
For next time
Issue is running out of questions and crash on popping an empty stack
- line 96 _ask_question method
- Business domain question : is it alright to ask a question twice ?
- If you run out of questions, shuffle the deck again.
Next step
- Implement reshuffling behaviour when stack is empty
We accept that we don't understand the code very well
We are half way through moving the questions to a seperate class
Need better test names
Medium term objective
- refactor 'roll' method
----
Observations
setting up environment was much faster than doing it alone
Did not use driver navigator pattern, but worked with three, don't think it would have worked with more people
We LIKE PyCharm!
Workflow for approval tests is not clear initially (Instance of Golden master pattern) - may need more detailed readme
Happy we achieved our goal
Kept goal small enough, and got there
Helpful to have someone familiar with approval tests, even in a different language
Always look at the error messages!
(Possible issue due to lack of formal structure)
We did not like the test code always emitting a warning.
Next week: Lets fix the warnings in Python Approvals Test library!