Merge pull request #4 from BetterStackHQ/alistair/avoid-overallocation

alistairjevans · web-flow · commit de0cdf9ad18a · 2026-02-25T13:55:58.000Z
Don't over-allocate for request bodies
diff --git a/ext/hyper_ruby/src/request.rs b/ext/hyper_ruby/src/request.rs
@@ -30,7 +30,7 @@ trait FillBuffer {
             let existing_capacity = rb_str_capacity(inner) as i64;
 
             if existing_capacity < body_len {
-                rb_str_modify_expand(inner, body_len);
+                rb_str_modify_expand(inner, body_len - existing_capacity);
             } else {
                 rb_str_modify(inner);
             }

Original file line number	Diff line number	Diff line change
`@@ -30,7 +30,7 @@ trait FillBuffer {`
`30`	`30`	`let existing_capacity = rb_str_capacity(inner) as i64;`
`31`	`31`
`32`	`32`	`if existing_capacity < body_len {`
`33`		`- rb_str_modify_expand(inner, body_len);`
	`33`	`+ rb_str_modify_expand(inner, body_len - existing_capacity);`
`34`	`34`	`} else {`
`35`	`35`	`rb_str_modify(inner);`
`36`	`36`	`}`