Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MacVim's url only works when file path is not encoded #102

Merged
merged 1 commit into from
Feb 5, 2013
Merged

MacVim's url only works when file path is not encoded #102

merged 1 commit into from
Feb 5, 2013

Conversation

lucascaton
Copy link
Contributor

No description provided.

@haileys
Copy link
Collaborator

haileys commented Feb 1, 2013

What happens if the filename contains a & character or something similarly funky?

Seems like a bug in MacVim that it doesn't accept encoded file paths.

@lucascaton
Copy link
Contributor Author

If the file name containing a strange character, that is wrong.
File names should never have special characters :-)

@milkfarm
Copy link

milkfarm commented Feb 3, 2013

+1

1 similar comment
@alinecaton
Copy link

+1

@haileys
Copy link
Collaborator

haileys commented Feb 5, 2013

Pulling in for now because I will admit that it's pretty unlikely for someone to have & in a filename.

I think this should be properly fixed upstream in MacVim though.

haileys pushed a commit that referenced this pull request Feb 5, 2013
MacVim's url only works when file path is not encoded
@haileys haileys merged commit 2167e22 into BetterErrors:master Feb 5, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants