Add scheme validation for all IRI's and IRL's (#180)

Co-authored-by: Thomas Turrell-Croft <tom@berrycloud.co.uk>

Author: Selindek

xapi-model/src/main/java/dev/learning/xapi/model/Account.java

@@ -6,6 +6,7 @@
 
 import com.fasterxml.jackson.annotation.JsonInclude;
 import com.fasterxml.jackson.annotation.JsonInclude.Include;
+import dev.learning.xapi.model.validation.constraints.HasScheme;
 import jakarta.validation.constraints.NotBlank;
 import jakarta.validation.constraints.NotNull;
 import java.net.URI;
@@ -30,6 +31,7 @@ public class Account {
    * The canonical home page for the system the account is on.
    */
   @NotNull
+  @HasScheme
   private URI homePage;
 
   /**

xapi-model/src/main/java/dev/learning/xapi/model/Activity.java

@@ -5,6 +5,7 @@
 package dev.learning.xapi.model;
 
 import com.fasterxml.jackson.annotation.JsonMerge;
+import dev.learning.xapi.model.validation.constraints.HasScheme;
 import dev.learning.xapi.model.validation.constraints.ValidActivityDefinition;
 import jakarta.validation.Valid;
 import jakarta.validation.constraints.NotNull;
@@ -34,6 +35,7 @@ public class Activity implements StatementObject, SubStatementObject {
    * An identifier for a single unique Activity.
    */
   @NotNull
+  @HasScheme
   private URI id;
 
   /**

xapi-model/src/main/java/dev/learning/xapi/model/ActivityDefinition.java

@@ -57,12 +57,14 @@ public class ActivityDefinition {
   /**
    * The type of Activity.
    */
+  @HasScheme
   private URI type;
 
   /**
    * Resolves to a document with human-readable information about the Activity, which could include
    * a way to launch the activity.
    */
+  @HasScheme
   private URI moreInfo;
 
   /**

xapi-model/src/main/java/dev/learning/xapi/model/Actor.java

@@ -11,6 +11,7 @@
 import com.fasterxml.jackson.annotation.JsonSubTypes;
 import com.fasterxml.jackson.annotation.JsonTypeInfo;
 import com.fasterxml.jackson.annotation.JsonTypeInfo.As;
+import dev.learning.xapi.model.validation.constraints.HasScheme;
 import dev.learning.xapi.model.validation.constraints.Mbox;
 import jakarta.validation.Valid;
 import java.net.URI;
@@ -63,6 +64,7 @@ public abstract class Actor implements StatementObject, SubStatementObject {
   /**
    * An openID.
    */
+  @HasScheme
   URI openid;
 
   /**

xapi-model/src/main/java/dev/learning/xapi/model/Attachment.java

@@ -7,6 +7,7 @@
 import com.fasterxml.jackson.annotation.JsonIgnore;
 import com.fasterxml.jackson.annotation.JsonInclude;
 import com.fasterxml.jackson.annotation.JsonInclude.Include;
+import dev.learning.xapi.model.validation.constraints.HasScheme;
 import jakarta.validation.constraints.NotNull;
 import jakarta.validation.valueextraction.Unwrapping;
 import java.net.URI;
@@ -37,6 +38,7 @@ public class Attachment {
    * Identifies the usage of this Attachment.
    */
   @NotNull
+  @HasScheme
   private URI usageType;
 
   /**
@@ -75,6 +77,7 @@ public class Attachment {
    * performs DNS lookups when calling equals and hashcode.
    * </p>
    */
+  @HasScheme
   private URI fileUrl;
 
   /**

xapi-model/src/test/java/dev/learning/xapi/model/AccountTests.java

@@ -185,4 +185,23 @@ void whenValidatingAccountWithEmptyNameThenConstraintViolationsSizeIsOne() {
 
   }
 
+  @Test
+  void whenValidatingAccountWithHomepageWithNoSchemeThenConstraintViolationsSizeIsOne() {
+
+    final var account = Account.builder()
+
+        .name("Example")
+
+        .homePage(URI.create("www.example.com"))
+
+        .build();
+
+    // When Validating Account With Homepage With No Scheme
+    final Set<ConstraintViolation<Account>> constraintViolations = validator.validate(account);
+
+    // Then ConstraintViolations Size Is One
+    assertThat(constraintViolations, hasSize(1));
+
+  }
+
 }