upgrade GHA to use shared workflows

Author: anarchivist

.github/workflows/build.yml

@@ -0,0 +1,14 @@
+name: Docker CI
+
+on:
+  push:
+  release:
+  workflow_dispatch:
+
+jobs:
+  build:
+    uses: BerkeleyLibrary/.github/.github/workflows/docker-build.yml@v1.1.0
+
+  test:
+    needs: build
+    uses: BerkeleyLibrary/.github/.github/workflows/docker-test.yml@v1.1.0

.github/workflows/docker-ci.yml

@@ -177,14 +177,14 @@ RUN SECRET_KEY_BASE=1 rails assets:precompile --trace
 ARG BUILD_TIMESTAMP
 ARG BUILD_URL
 ARG DOCKER_TAG
-ARG GIT_BRANCH
-ARG GIT_COMMIT
-ARG GIT_URL
+ARG GIT_REF_NAME
+ARG GIT_SHA
+ARG GIT_REPOSITORY_URL
 
 # build arguments aren't persisted in the image, but ENV values are
 ENV BUILD_TIMESTAMP="${BUILD_TIMESTAMP}"
 ENV BUILD_URL="${BUILD_URL}"
 ENV DOCKER_TAG="${DOCKER_TAG}"
-ENV GIT_BRANCH="${GIT_BRANCH}"
-ENV GIT_COMMIT="${GIT_COMMIT}"
-ENV GIT_URL="${GIT_URL}"
+ENV GIT_REF_NAME="${GIT_REF_NAME}"
+ENV GIT_SHA="${GIT_SHA}"
+ENV GIT_REPOSITORY_URL="${GIT_REPOSITORY_URL}"

.github/workflows/release.yml

@@ -1,28 +1,16 @@
 #!/usr/bin/env ruby
-require 'fileutils'
+require "fileutils"
 
-# path to your application root.
-APP_ROOT = File.expand_path('..', __dir__)
+APP_ROOT = File.expand_path("..", __dir__)
 
 def system!(*args)
   system(*args) || abort("\n== Command #{args} failed ==")
 end
 
 FileUtils.chdir APP_ROOT do
-  # This script is a way to setup or update your development environment automatically.
-  # This script is idempotent, so that you can run it at anytime and get an expectable outcome.
-  # Add necessary setup steps to this file.
-
-  puts '== Installing dependencies =='
-  system! 'gem install bundler --conservative'
-  system('bundle check') || system!('bundle install')
-
-  # Install JavaScript dependencies
-  # system('bin/yarn')
-
   puts "\n== Removing old logs and tempfiles =="
-  system! 'bin/rails log:clear tmp:clear'
+  system! "bin/rails log:clear tmp:clear"
 
   puts "\n== Restarting application server =="
-  system! 'bin/rails restart'
+  system! "bin/rails restart"
 end

Dockerfile

@@ -0,0 +1,17 @@
+#!/usr/bin/env ruby
+require "fileutils"
+
+APP_ROOT = File.expand_path("..", __dir__)
+
+# Check test coverage when running rspec
+ENV['COVERAGE'] = '1'
+
+# Test commands (to be exec'd in order)
+TESTS = [
+  %w(rspec -f html --out artifacts/rspec.html),
+  %w(rubocop -f html --out artifacts/rubocop.html),
+]
+
+FileUtils.chdir APP_ROOT do
+  exit TESTS.reduce(true) { |passed, test| system(*test) && passed }
+end

bin/setup

@@ -9,7 +9,7 @@ class BuildInfo
     MULTIPLE_HYPHEN_ESCAPE_RE = /((?<=-)-)|(-(?=-))/
     HYPHEN_ENTITY_ESCAPE = '&#45;'.freeze
 
-    BUILD_VARS = %w[CI BUILD_TIMESTAMP BUILD_URL DOCKER_TAG GIT_BRANCH GIT_COMMIT GIT_URL].freeze
+    BUILD_VARS = %w[CI BUILD_TIMESTAMP BUILD_URL DOCKER_TAG GIT_REF_NAME GIT_SHA GIT_REPOSITORY_URL].freeze
 
     attr_reader :info
 

bin/test

@@ -0,0 +1,13 @@
+---
+
+services:
+  app:
+    build: !reset
+    image: ${DOCKER_APP_IMAGE}
+    volumes: !reset
+    volumes:
+      - artifacts:/opt/app/artifacts
+
+volumes:
+  artifacts:
+

config/initializers/build_info.rb

@@ -11,9 +11,9 @@ module AvPlayer
           BUILD_TIMESTAMP: '2021-03-22T21:57:07+0000',
           BUILD_URL: 'https://jenkins.lib.berkeley.edu/job/gitlab/job/lap/job/lap%252Favplayer/job/LIT-2266-build-args/1/',
           DOCKER_TAG: 'containers.lib.berkeley.edu/lap/avplayer/lit-2266-build-args:build-1',
-          GIT_BRANCH: 'LIT-2266-build-args',
-          GIT_COMMIT: 'e2493452b7e6ebe98856fa3aff6b2c8f24063586',
-          GIT_URL: 'git@git.lib.berkeley.edu:lap/avplayer.git'
+          GIT_REF_NAME: 'LIT-2266-build-args',
+          GIT_SHA: 'e2493452b7e6ebe98856fa3aff6b2c8f24063586',
+          GIT_REPOSITORY_URL: 'git@git.lib.berkeley.edu:lap/avplayer.git'
         }.freeze
       end