test/prif_init_test: Remove superfluous memoization on check_caffeination

Julienne guarantees that `test_fixture_t` elements in a `test_harness_t` are
executed strictly in-order, so we don't need a hack to ensure proper
initialization ordering.

Author: bonachea

test/julienne-driver.F90

@@ -17,7 +17,7 @@ program test_suite_driver
   implicit none
 
   associate(test_harness => test_harness_t([ &
-     test_fixture_t( prif_init_test_t() ) &
+     test_fixture_t( prif_init_test_t() ) &  ! must come first
     ,test_fixture_t( prif_num_images_test_t() ) &
     ,test_fixture_t( prif_this_image_no_coarray_test_t() ) &
     ,test_fixture_t( prif_image_queries_test_t() ) &

test/prif_init_test.F90

@@ -31,28 +31,16 @@ function results() result(test_results)
 
 
   function check_caffeination() result(diag)
-    ! this test needs to run very early at startup, so we memoize the result
     type(test_diagnosis_t) :: diag
-    type(test_diagnosis_t), save :: memo
-    logical, save :: first_pass = .true.
-
-    if (first_pass) then
-      first_pass = .false.
-      write_memo: &
-      block
 #if HAVE_MULTI_IMAGE
-        integer, parameter :: successful_initiation = PRIF_STAT_ALREADY_INIT
+    integer, parameter :: successful_initiation = PRIF_STAT_ALREADY_INIT
 #else
-        integer, parameter :: successful_initiation = 0
+    integer, parameter :: successful_initiation = 0
 #endif
-        integer init_exit_code
-
-        call prif_init(init_exit_code)
-        memo = init_exit_code .equalsExpected. successful_initiation
-      end block write_memo
-    endif 
+    integer init_exit_code
 
-    diag = memo
+    call prif_init(init_exit_code)
+    diag = init_exit_code .equalsExpected. successful_initiation
   end function
 
   function check_subsequent_prif_init_call() result(diag)