Skip to content

Update ecs.hpp #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update ecs.hpp #3

wants to merge 1 commit into from

Conversation

jamesn031199
Copy link

A better way to handle a variable amount of components passed to the makeEntity function

moose99
moose99 reviewed Jul 14, 2018
View reviewed changes
Copy link

@moose99 moose99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, I like this as well. Only problem is that remove_reference is c++-11 and remove_reference_t is c++-14. I believe Benny prefers to keep pre-c++-11 compatibility.

@jamesn031199
Copy link
Author

Do you know of a way to get around this issue?

@moose99
Copy link

moose99 commented Jul 15, 2018

I don't think there's any way around it. Variadic templates were introduced in c++-11 and prior to that there were only variadic functions which I don't think will suffice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@moose99 moose99 moose99 left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jamesn031199 @moose99 @jarann