You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
we've started using this project as an ODM and also for data migrations. It serves its purpose very well! I have a suggestion for you to consider.
It would be great if the name provided by the caller of bunnet new-migration command was sanitized to only contain letters, numbers, and underscores. That way the final file name (module name) would conform to https://peps.python.org/pep-0008/#package-and-module-names
We've had a case where hyphens were used as part of the migration name and it confused IntelliJ IDEA when trying to run a unit test for that module. It would be great if we were guarded against that by the library itself.
Hi, thank you for the feedback.
Yup, you are right. Yes then, I'll change the format. I plan to make the format configurable, but the default one must follow the PEP
Hi @roman-right,
we've started using this project as an ODM and also for data migrations. It serves its purpose very well! I have a suggestion for you to consider.
It would be great if the
name
provided by the caller ofbunnet new-migration
command was sanitized to only contain letters, numbers, and underscores. That way the final file name (module name) would conform to https://peps.python.org/pep-0008/#package-and-module-namesWe've had a case where hyphens were used as part of the migration name and it confused IntelliJ IDEA when trying to run a unit test for that module. It would be great if we were guarded against that by the library itself.
I believe this could be changed here:
https://github.com/roman-right/bunnet/blob/748cae319314b55f4683ef5b83f8d154f4cec2df/bunnet/executors/migrate.py#L166
The text was updated successfully, but these errors were encountered: