WIP: Add missing type check to method calls #2531
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
The exact rules are still being discussed (qt4cg/qtspecs#2219). I’ll wait with the merge until we’ve chosen what to do. |
ChristianGruen
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The spec, in 4.14.4 Method Calls, requires a map that goes into a method call to have an entry with the given key that is a single function item. Implementation-wise this used to be checked implicitly by the involved dynamic function call, because until recently that required a single function item as well. However with that changed to allowing a sequence of zero or more function items, an extra type check becomes necessary for method calls, which is added here.
This fixes QT4 test cases
method-902andmethod-904.